Skip to content

Commit af79479

Browse files
committed
Fixed "Changing the seeks duration does not update the displayed seconds"
1 parent 54ef604 commit af79479

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

app/src/main/java/org/schabi/newpipe/player/Player.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,8 @@ public void onChange(final boolean selfChange) {
586586
*/
587587
private void setupPlayerSeekOverlay() {
588588
binding.fastSeekOverlay
589-
.seekSeconds((int) (retrieveSeekDurationFromPreferences(this) / 1000.0f))
589+
.seekSecondsSupplier(
590+
() -> (int) (retrieveSeekDurationFromPreferences(this) / 1000.0f))
590591
.performListener(new PlayerFastSeekOverlay.PerformListener() {
591592

592593
@Override

app/src/main/java/org/schabi/newpipe/views/player/PlayerFastSeekOverlay.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,10 @@ class PlayerFastSeekOverlay(context: Context, attrs: AttributeSet?) :
4242
performListener = listener
4343
}
4444

45-
var seekSeconds: Int = 0
46-
private set
45+
private var seekSecondsSupplier: () -> Int = { 0 }
4746

48-
fun seekSeconds(seconds: Int) = apply {
49-
seekSeconds = seconds
47+
fun seekSecondsSupplier(supplier: () -> Int) = apply {
48+
seekSecondsSupplier = supplier
5049
}
5150

5251
// Indicates whether this (double) tap is the first of a series
@@ -94,7 +93,7 @@ class PlayerFastSeekOverlay(context: Context, attrs: AttributeSet?) :
9493

9594
performListener?.onDoubleTap()
9695

97-
secondsView.seconds += seekSeconds
96+
secondsView.seconds += seekSecondsSupplier.invoke()
9897
performListener?.seek(forward = shouldForward)
9998
}
10099

0 commit comments

Comments
 (0)