ListHelper.getFilteredAudioStreams short circuit on empty list

absurdlylongusername · absurdlylongusername · commit af755215f2be · 2025-07-08T14:40:13.000+01:00
diff --git a/app/src/main/java/org/schabi/newpipe/util/ListHelper.java b/app/src/main/java/org/schabi/newpipe/util/ListHelper.java
@@ -293,7 +293,7 @@ public static boolean isHighResolutionSelected(final String selectedResolution,
     public static List<AudioStream> getFilteredAudioStreams(
             @NonNull final Context context,
             @Nullable final List<AudioStream> audioStreams) {
-        if (audioStreams == null) {
+        if (audioStreams == null || audioStreams.isEmpty()) {
             return Collections.emptyList();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ public static boolean isHighResolutionSelected(final String selectedResolution,`
`293`	`293`	`public static List<AudioStream> getFilteredAudioStreams(`
`294`	`294`	`@NonNull final Context context,`
`295`	`295`	`@Nullable final List<AudioStream> audioStreams) {`
`296`		`- if (audioStreams == null) {`
	`296`	`+ if (audioStreams == null \|\| audioStreams.isEmpty()) {`
`297`	`297`	`return Collections.emptyList();`
`298`	`298`	`}`
`299`	`299`