Merge pull request #6493 from TeamNewPipe/hotfix-v0.21.5

TobiGr · web-flow · commit a98c0bdec7aa · 2021-06-15T23:58:52.000+02:00
Hotfix release 0.21.5
diff --git a/app/build.gradle b/app/build.gradle
@@ -17,8 +17,8 @@ android {
         resValue "string", "app_name", "NewPipe"
         minSdkVersion 19
         targetSdkVersion 29
-        versionCode 970
-        versionName "0.21.4"
+        versionCode 971
+        versionName "0.21.5"
 
         multiDexEnabled true
 
diff --git a/app/src/main/java/org/schabi/newpipe/player/helper/LoadController.java b/app/src/main/java/org/schabi/newpipe/player/helper/LoadController.java
@@ -32,7 +32,8 @@ private LoadController(final int initialPlaybackBufferMs,
 
         final DefaultLoadControl.Builder builder = new DefaultLoadControl.Builder();
         builder.setBufferDurationsMs(minimumPlaybackBufferMs, optimalPlaybackBufferMs,
-                initialPlaybackBufferMs, initialPlaybackBufferMs);
+                initialPlaybackBufferMs,
+                DefaultLoadControl.DEFAULT_BUFFER_FOR_PLAYBACK_AFTER_REBUFFER_MS);
         internalLoadControl = builder.build();
     }
 
diff --git a/app/src/main/res/layout-large-land/player.xml b/app/src/main/res/layout-large-land/player.xml
@@ -563,6 +563,17 @@
                 android:tint="?attr/colorAccent"
                 app:srcCompat="@drawable/ic_shuffle"
                 tools:ignore="ContentDescription,RtlHardcoded" />
+
+            <androidx.appcompat.widget.AppCompatTextView
+                android:id="@+id/itemsListHeaderDuration"
+                style="@style/TextAppearance.AppCompat.Medium"
+                android:layout_width="wrap_content"
+                android:layout_height="wrap_content"
+                android:layout_centerVertical="true"
+                android:layout_toLeftOf="@id/itemsListClose"
+                android:layout_toRightOf="@id/shuffleButton"
+                android:gravity="center"
+                android:textColor="@android:color/white" />
         </RelativeLayout>
 
         <androidx.recyclerview.widget.RecyclerView
diff --git a/fastlane/metadata/android/en-US/changelogs/971.txt b/fastlane/metadata/android/en-US/changelogs/971.txt
@@ -0,0 +1,3 @@
+Hotfix
+• Increase buffer for playback after rebuffer
+• Fixed crash on tablets and TVs when clicking on the play-queue icon in the player

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ private LoadController(final int initialPlaybackBufferMs,`
`32`	`32`
`33`	`33`	`final DefaultLoadControl.Builder builder = new DefaultLoadControl.Builder();`
`34`	`34`	`builder.setBufferDurationsMs(minimumPlaybackBufferMs, optimalPlaybackBufferMs,`
`35`		`- initialPlaybackBufferMs, initialPlaybackBufferMs);`
	`35`	`+ initialPlaybackBufferMs,`
	`36`	`+ DefaultLoadControl.DEFAULT_BUFFER_FOR_PLAYBACK_AFTER_REBUFFER_MS);`
`36`	`37`	`internalLoadControl = builder.build();`
`37`	`38`	`}`
`38`	`39`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Hotfix`
	`2`	`+• Increase buffer for playback after rebuffer`
	`3`	`+• Fixed crash on tablets and TVs when clicking on the play-queue icon in the player`