Skip to content

Commit a209e87

Browse files
committed
Add Loading Channel Details Toast
1 parent 967bdf8 commit a209e87

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

app/src/main/java/org/schabi/newpipe/util/StreamDialogEntry.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ public enum StreamDialogEntry {
3737
if (isNullOrEmpty(item.getUploaderUrl())) {
3838
final int serviceId = item.getServiceId();
3939
final String url = item.getUrl();
40-
// TODO: Some visual loading indicator
40+
Toast.makeText(fragment.getContext(), R.string.loading_channel_details,
41+
Toast.LENGTH_SHORT).show();
4142
ExtractorHelper.getStreamInfo(serviceId, url, false)
4243
.subscribeOn(Schedulers.io())
4344
.observeOn(AndroidSchedulers.mainThread())
@@ -46,7 +47,7 @@ public enum StreamDialogEntry {
4647
.setUploaderUrl(serviceId, url, result.getUploaderUrl())
4748
.subscribeOn(Schedulers.io()).subscribe();
4849
openChannelFragment(fragment, item, result.getUploaderUrl());
49-
}, throwable -> Toast.makeText(
50+
}, throwable -> Toast.makeText( // TODO: Open the Error Activity
5051
fragment.getContext(),
5152
R.string.error_show_channel_details,
5253
Toast.LENGTH_SHORT

app/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -755,5 +755,7 @@
755755
<string name="tablet_mode_title">Tablet mode</string>
756756
<string name="on">On</string>
757757
<string name="off">Off</string>
758+
<!-- Show Channel Details -->
758759
<string name="error_show_channel_details">Error at Show Channel Details</string>
760+
<string name="loading_channel_details">Loading Channel Details…</string>
759761
</resources>

0 commit comments

Comments
 (0)