updated: source loading error for FailedMediaSource to wait for 3 seconds before allowing retry.

updated: minor style fixes.

Author: karyogamy

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -2487,11 +2487,11 @@ private void setMuteButton(@NonNull final ImageButton button, final boolean isMu
     /**
      * <p>Listens for event or state changes on ExoPlayer. When any event happens, we check for
      * changes in the currently-playing metadata and update the encapsulating
-     * {@link Player}. Downstream listeners are also informed.
+     * {@link Player}. Downstream listeners are also informed.</p>
      *
      * <p>When the renewed metadata contains any error, it is reported as a notification.
      * This is done because not all source resolution errors are {@link PlaybackException}, which
-     * are also captured by {@link ExoPlayer} and stops the playback.
+     * are also captured by {@link ExoPlayer} and stops the playback.</p>
      *
      * @param player The {@link com.google.android.exoplayer2.Player} whose state changed.
      * @param events The {@link com.google.android.exoplayer2.Player.Events} that has triggered
@@ -2634,6 +2634,9 @@ public void onCues(@NonNull final List<Cue> cues) {
      * </ul>
      * @see com.google.android.exoplayer2.Player.Listener#onPlayerError(PlaybackException)
      * */
+    // Any error code not explicitly covered here are either unrelated to NewPipe use case
+    // (e.g. DRM) or not recoverable (e.g. Decoder error). In both cases, the player should
+    // shutdown.
     @SuppressLint("SwitchIntDef")
     @Override
     public void onPlayerError(@NonNull final PlaybackException error) {

app/src/main/java/org/schabi/newpipe/player/mediasource/FailedMediaSource.java

@@ -78,7 +78,7 @@ public PlayQueueItem getStream() {
         return playQueueItem;
     }
 
-    public Throwable getError() {
+    public Exception getError() {
         return error;
     }
 

app/src/main/java/org/schabi/newpipe/player/playback/MediaSourceManager.java

@@ -441,8 +441,10 @@ private Single<ManagedMediaSource> getLoadedMediaSource(@NonNull final PlayQueue
             if (throwable instanceof ExtractionException) {
                 return FailedMediaSource.of(stream, new StreamInfoLoadException(throwable));
             }
-            return FailedMediaSource
-                    .of(stream, new Exception(throwable), /*immediatelyRetryable=*/0L);
+            // Non-source related error expected here (e.g. network),
+            // should allow retry shortly after the error.
+            return FailedMediaSource.of(stream, new Exception(throwable),
+                    /*allowRetryIn=*/TimeUnit.MILLISECONDS.convert(3, TimeUnit.SECONDS));
         });
     }