Use Optional.map correctly and other improvements

Author: Stypox

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java

@@ -255,7 +255,9 @@ public void onServiceConnected(final Player connectedPlayer,
             playerUi.ifPresent(MainPlayerUi::toggleFullscreen);
         }
 
-        if (playAfterConnect || (currentInfo != null && isAutoplayEnabled()
+        if (playAfterConnect
+                || (currentInfo != null
+                && isAutoplayEnabled()
                 && playerUi.isEmpty())) {
             autoPlayEnabled = true; // forcefully start playing
             openVideoPlayerAutoFullscreen();
@@ -1883,8 +1885,9 @@ public void onServiceStopped() {
     @Override
     public void onFullscreenStateChanged(final boolean fullscreen) {
         setupBrightness();
-        if (!isPlayerAndPlayerServiceAvailable() || player.UIs().get(MainPlayerUi.class).isEmpty()
-                || getRoot().map(View::getParent).isEmpty()) {
+        if (!isPlayerAndPlayerServiceAvailable()
+                || player.UIs().get(MainPlayerUi.class).isEmpty()
+                || getRoot().flatMap(v -> Optional.ofNullable(v.getParent())).isEmpty()) {
             return;
         }
 

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -1875,8 +1875,7 @@ public void disablePreloadingOfCurrentTrack() {
         loadController.disablePreloadingOfCurrentTrack();
     }
 
-    @Nullable
-    public VideoStream getSelectedVideoStream() {
+    public Optional<VideoStream> getSelectedVideoStream() {
         return Optional.ofNullable(currentMetadata)
                 .flatMap(MediaItemTag::getMaybeQuality)
                 .filter(quality -> {
@@ -1885,8 +1884,7 @@ public VideoStream getSelectedVideoStream() {
                             && selectedStreamIndex < quality.getSortedVideoStreams().size();
                 })
                 .map(quality -> quality.getSortedVideoStreams()
-                        .get(quality.getSelectedVideoStreamIndex()))
-                .orElse(null);
+                        .get(quality.getSelectedVideoStreamIndex()));
     }
     //endregion
 

app/src/main/java/org/schabi/newpipe/player/mediaitem/MediaItemTag.java

@@ -62,8 +62,8 @@ default Optional<Quality> getMaybeQuality() {
     @NonNull
     static Optional<MediaItemTag> from(@Nullable final MediaItem mediaItem) {
         return Optional.ofNullable(mediaItem)
-                .map(item -> item.localConfiguration)
-                .map(localConfiguration -> localConfiguration.tag)
+                .flatMap(item -> Optional.ofNullable(item.localConfiguration))
+                .flatMap(localConfiguration -> Optional.ofNullable(localConfiguration.tag))
                 .filter(MediaItemTag.class::isInstance)
                 .map(MediaItemTag.class::cast);
     }

app/src/main/java/org/schabi/newpipe/player/ui/VideoPlayerUi.java

@@ -1060,12 +1060,11 @@ private void buildQualityMenu() {
             qualityPopupMenu.getMenu().add(POPUP_MENU_ID_QUALITY, i, Menu.NONE, MediaFormat
                     .getNameById(videoStream.getFormatId()) + " " + videoStream.getResolution());
         }
-        final VideoStream selectedVideoStream = player.getSelectedVideoStream();
-        if (selectedVideoStream != null) {
-            binding.qualityTextView.setText(selectedVideoStream.getResolution());
-        }
         qualityPopupMenu.setOnMenuItemClickListener(this);
         qualityPopupMenu.setOnDismissListener(this);
+
+        player.getSelectedVideoStream()
+                .ifPresent(s -> binding.qualityTextView.setText(s.getResolution()));
     }
 
     private void buildPlaybackSpeedMenu() {
@@ -1171,12 +1170,9 @@ private void onQualityClicked() {
         qualityPopupMenu.show();
         isSomePopupMenuVisible = true;
 
-        final VideoStream videoStream = player.getSelectedVideoStream();
-        if (videoStream != null) {
-            //noinspection SetTextI18n
-            binding.qualityTextView.setText(MediaFormat.getNameById(videoStream.getFormatId())
-                    + " " + videoStream.getResolution());
-        }
+        player.getSelectedVideoStream()
+                .map(s -> MediaFormat.getNameById(s.getFormatId()) + " " + s.getResolution())
+                .ifPresent(binding.qualityTextView::setText);
     }
 
     /**
@@ -1232,10 +1228,9 @@ public void onDismiss(@Nullable final PopupMenu menu) {
             Log.d(TAG, "onDismiss() called with: menu = [" + menu + "]");
         }
         isSomePopupMenuVisible = false; //TODO check if this works
-        final VideoStream selectedVideoStream = player.getSelectedVideoStream();
-        if (selectedVideoStream != null) {
-            binding.qualityTextView.setText(selectedVideoStream.getResolution());
-        }
+        player.getSelectedVideoStream()
+                .ifPresent(s -> binding.qualityTextView.setText(s.getResolution()));
+
         if (player.isPlaying()) {
             hideControls(DEFAULT_CONTROLS_DURATION, 0);
             hideSystemUIIfNeeded();