Skip to content

Commit 90979e2

Browse files
committed
Fix PlaylistLocalItemTest
1 parent e66e1b5 commit 90979e2

2 files changed

Lines changed: 14 additions & 13 deletions

File tree

app/src/main/java/org/schabi/newpipe/local/bookmark/MergedPlaylistManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public static Flowable<List<PlaylistLocalItem>> getMergedOrderedPlaylists(
3939
* @param remotePlaylists remote playlists, already sorted by display index
4040
* @return merged playlists
4141
*/
42-
private static List<PlaylistLocalItem> merge(
42+
public static List<PlaylistLocalItem> merge(
4343
final List<PlaylistMetadataEntry> localPlaylists,
4444
final List<PlaylistRemoteEntity> remotePlaylists) {
4545

app/src/test/java/org/schabi/newpipe/database/playlist/PlaylistLocalItemTest.java

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import org.junit.Test;
77
import org.schabi.newpipe.database.playlist.model.PlaylistRemoteEntity;
8+
import org.schabi.newpipe.local.bookmark.MergedPlaylistManager;
89

910
import java.util.ArrayList;
1011
import java.util.List;
@@ -15,7 +16,7 @@ public void emptyPlaylists() {
1516
final List<PlaylistMetadataEntry> localPlaylists = new ArrayList<>();
1617
final List<PlaylistRemoteEntity> remotePlaylists = new ArrayList<>();
1718
final List<PlaylistLocalItem> mergedPlaylists =
18-
PlaylistLocalItem.merge(localPlaylists, remotePlaylists);
19+
MergedPlaylistManager.merge(localPlaylists, remotePlaylists);
1920

2021
assertEquals(0, mergedPlaylists.size());
2122
}
@@ -24,11 +25,11 @@ public void emptyPlaylists() {
2425
public void onlyLocalPlaylists() {
2526
final List<PlaylistMetadataEntry> localPlaylists = new ArrayList<>();
2627
final List<PlaylistRemoteEntity> remotePlaylists = new ArrayList<>();
27-
localPlaylists.add(new PlaylistMetadataEntry(1, "name1", "", 0, 1));
28-
localPlaylists.add(new PlaylistMetadataEntry(2, "name2", "", 1, 1));
29-
localPlaylists.add(new PlaylistMetadataEntry(3, "name3", "", 3, 1));
28+
localPlaylists.add(new PlaylistMetadataEntry(1, "name1", "", false, -1, 0, 1));
29+
localPlaylists.add(new PlaylistMetadataEntry(2, "name2", "", false, -1, 1, 1));
30+
localPlaylists.add(new PlaylistMetadataEntry(3, "name3", "", false, -1, 3, 1));
3031
final List<PlaylistLocalItem> mergedPlaylists =
31-
PlaylistLocalItem.merge(localPlaylists, remotePlaylists);
32+
MergedPlaylistManager.merge(localPlaylists, remotePlaylists);
3233

3334
assertEquals(3, mergedPlaylists.size());
3435
assertEquals(0, mergedPlaylists.get(0).getDisplayIndex());
@@ -47,7 +48,7 @@ public void onlyRemotePlaylists() {
4748
remotePlaylists.add(new PlaylistRemoteEntity(
4849
3, "name3", "url3", "", "", 4, 1L));
4950
final List<PlaylistLocalItem> mergedPlaylists =
50-
PlaylistLocalItem.merge(localPlaylists, remotePlaylists);
51+
MergedPlaylistManager.merge(localPlaylists, remotePlaylists);
5152

5253
assertEquals(3, mergedPlaylists.size());
5354
assertEquals(1, mergedPlaylists.get(0).getDisplayIndex());
@@ -59,14 +60,14 @@ public void onlyRemotePlaylists() {
5960
public void sameIndexWithDifferentName() {
6061
final List<PlaylistMetadataEntry> localPlaylists = new ArrayList<>();
6162
final List<PlaylistRemoteEntity> remotePlaylists = new ArrayList<>();
62-
localPlaylists.add(new PlaylistMetadataEntry(1, "name1", "", 0, 1));
63-
localPlaylists.add(new PlaylistMetadataEntry(2, "name2", "", 1, 1));
63+
localPlaylists.add(new PlaylistMetadataEntry(1, "name1", "", false, -1, 0, 1));
64+
localPlaylists.add(new PlaylistMetadataEntry(2, "name2", "", false, -1, 1, 1));
6465
remotePlaylists.add(new PlaylistRemoteEntity(
6566
1, "name3", "url1", "", "", 0, 1L));
6667
remotePlaylists.add(new PlaylistRemoteEntity(
6768
2, "name4", "url2", "", "", 1, 1L));
6869
final List<PlaylistLocalItem> mergedPlaylists =
69-
PlaylistLocalItem.merge(localPlaylists, remotePlaylists);
70+
MergedPlaylistManager.merge(localPlaylists, remotePlaylists);
7071

7172
assertEquals(4, mergedPlaylists.size());
7273
assertTrue(mergedPlaylists.get(0) instanceof PlaylistMetadataEntry);
@@ -83,14 +84,14 @@ public void sameIndexWithDifferentName() {
8384
public void sameNameWithDifferentIndex() {
8485
final List<PlaylistMetadataEntry> localPlaylists = new ArrayList<>();
8586
final List<PlaylistRemoteEntity> remotePlaylists = new ArrayList<>();
86-
localPlaylists.add(new PlaylistMetadataEntry(1, "name1", "", 1, 1));
87-
localPlaylists.add(new PlaylistMetadataEntry(2, "name2", "", 3, 1));
87+
localPlaylists.add(new PlaylistMetadataEntry(1, "name1", "", false, -1, 1, 1));
88+
localPlaylists.add(new PlaylistMetadataEntry(2, "name2", "", false, -1, 3, 1));
8889
remotePlaylists.add(new PlaylistRemoteEntity(
8990
1, "name1", "url1", "", "", 0, 1L));
9091
remotePlaylists.add(new PlaylistRemoteEntity(
9192
2, "name2", "url2", "", "", 2, 1L));
9293
final List<PlaylistLocalItem> mergedPlaylists =
93-
PlaylistLocalItem.merge(localPlaylists, remotePlaylists);
94+
MergedPlaylistManager.merge(localPlaylists, remotePlaylists);
9495

9596
assertEquals(4, mergedPlaylists.size());
9697
assertTrue(mergedPlaylists.get(0) instanceof PlaylistRemoteEntity);

0 commit comments

Comments
 (0)