Code improvements here and there

Author: Stypox

app/src/main/java/org/schabi/newpipe/download/DownloadDialog.java

@@ -786,10 +786,8 @@ private void prepareSelectedDownload() {
 
                 if (format == MediaFormat.TTML) {
                     filenameTmp += MediaFormat.SRT.suffix;
-                } else {
-                    if (format != null) {
-                        filenameTmp += format.suffix;
-                    }
+                } else if (format != null) {
+                    filenameTmp += format.suffix;
                 }
                 break;
             default:

app/src/main/java/org/schabi/newpipe/util/SecondaryStreamHelper.java

@@ -35,33 +35,35 @@ public SecondaryStreamHelper(@NonNull final StreamSizeWrapper<T> streams,
     public static AudioStream getAudioStreamFor(@NonNull final List<AudioStream> audioStreams,
                                                 @NonNull final VideoStream videoStream) {
         final MediaFormat mediaFormat = videoStream.getFormat();
-        if (mediaFormat != null) {
-            switch (mediaFormat) {
-                case WEBM:
-                case MPEG_4:// ¿is mpeg-4 DASH?
-                    break;
-                default:
-                    return null;
-            }
+        if (mediaFormat == null) {
+            return null;
+        }
 
-            final boolean m4v = (mediaFormat == MediaFormat.MPEG_4);
+        switch (mediaFormat) {
+            case WEBM:
+            case MPEG_4:// ¿is mpeg-4 DASH?
+                break;
+            default:
+                return null;
+        }
 
-            for (final AudioStream audio : audioStreams) {
-                if (audio.getFormat() == (m4v ? MediaFormat.M4A : MediaFormat.WEBMA)) {
-                    return audio;
-                }
-            }
+        final boolean m4v = (mediaFormat == MediaFormat.MPEG_4);
 
-            if (m4v) {
-                return null;
+        for (final AudioStream audio : audioStreams) {
+            if (audio.getFormat() == (m4v ? MediaFormat.M4A : MediaFormat.WEBMA)) {
+                return audio;
             }
+        }
+
+        if (m4v) {
+            return null;
+        }
 
-            // retry, but this time in reverse order
-            for (int i = audioStreams.size() - 1; i >= 0; i--) {
-                final AudioStream audio = audioStreams.get(i);
-                if (audio.getFormat() == MediaFormat.WEBMA_OPUS) {
-                    return audio;
-                }
+        // retry, but this time in reverse order
+        for (int i = audioStreams.size() - 1; i >= 0; i--) {
+            final AudioStream audio = audioStreams.get(i);
+            if (audio.getFormat() == MediaFormat.WEBMA_OPUS) {
+                return audio;
             }
         }
 

app/src/main/java/org/schabi/newpipe/util/StreamItemAdapter.java

@@ -155,10 +155,10 @@ private View getCustomView(final int position,
                 qualityString += " (" + context.getString(R.string.caption_auto_generated) + ")";
             }
         } else {
-            if (mediaFormat != null) {
-                qualityString = mediaFormat.getSuffix();
-            } else {
+            if (mediaFormat == null) {
                 qualityString = context.getString(R.string.unknown_quality);
+            } else {
+                qualityString = mediaFormat.getSuffix();
             }
         }