Merge pull request #12949 from dustdfg/unnecessary_get_resources

Use context.getString() shorthand instead of context.getResources().getString()

Author: TobiGr

app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java

@@ -141,11 +141,11 @@ public static String resizeTypeOf(@NonNull final Context context,
                                       @ResizeMode final int resizeMode) {
         switch (resizeMode) {
             case AspectRatioFrameLayout.RESIZE_MODE_FIT:
-                return context.getResources().getString(R.string.resize_fit);
+                return context.getString(R.string.resize_fit);
             case AspectRatioFrameLayout.RESIZE_MODE_FILL:
-                return context.getResources().getString(R.string.resize_fill);
+                return context.getString(R.string.resize_fill);
             case AspectRatioFrameLayout.RESIZE_MODE_ZOOM:
-                return context.getResources().getString(R.string.resize_zoom);
+                return context.getString(R.string.resize_zoom);
             case AspectRatioFrameLayout.RESIZE_MODE_FIXED_HEIGHT:
             case AspectRatioFrameLayout.RESIZE_MODE_FIXED_WIDTH:
             default:

app/src/main/java/org/schabi/newpipe/util/Localization.java

@@ -194,9 +194,9 @@ public static String localizeStreamCount(@NonNull final Context context,
             case (int) ListExtractor.ITEM_COUNT_UNKNOWN:
                 return "";
             case (int) ListExtractor.ITEM_COUNT_INFINITE:
-                return context.getResources().getString(R.string.infinite_videos);
+                return context.getString(R.string.infinite_videos);
             case (int) ListExtractor.ITEM_COUNT_MORE_THAN_100:
-                return context.getResources().getString(R.string.more_than_100_videos);
+                return context.getString(R.string.more_than_100_videos);
             default:
                 return getQuantity(context, R.plurals.videos, R.string.no_videos, streamCount,
                         localizeNumber(streamCount));
@@ -209,9 +209,9 @@ public static String localizeStreamCountMini(@NonNull final Context context,
             case (int) ListExtractor.ITEM_COUNT_UNKNOWN:
                 return "";
             case (int) ListExtractor.ITEM_COUNT_INFINITE:
-                return context.getResources().getString(R.string.infinite_videos_mini);
+                return context.getString(R.string.infinite_videos_mini);
             case (int) ListExtractor.ITEM_COUNT_MORE_THAN_100:
-                return context.getResources().getString(R.string.more_than_100_videos_mini);
+                return context.getString(R.string.more_than_100_videos_mini);
             default:
                 return String.valueOf(streamCount);
         }

app/src/main/java/org/schabi/newpipe/util/ThemeHelper.java

@@ -263,7 +263,7 @@ public static int getAndroidDimenPx(@NonNull final Context context, final String
 
     private static String getSelectedThemeKey(final Context context) {
         final String themeKey = context.getString(R.string.theme_key);
-        final String defaultTheme = context.getResources().getString(R.string.default_theme_value);
+        final String defaultTheme = context.getString(R.string.default_theme_value);
         return PreferenceManager.getDefaultSharedPreferences(context)
                 .getString(themeKey, defaultTheme);
     }