Skip to content

Commit 85c5f5a

Browse files
SttApolloSttApollo
committed
test,ui: move comment error tests to error; remove unused ComposeView
1 parent fab0d35 commit 85c5f5a

4 files changed

Lines changed: 201 additions & 15 deletions

File tree

app/src/androidTest/java/org/schabi/newpipe/ui/components/common/CommentSectionErrorTest.kt renamed to app/src/androidTest/java/org/schabi/newpipe/error/ErrorInfoCommentsTest.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.schabi.newpipe.ui.components.common
1+
package org.schabi.newpipe.error
22

33
import android.content.Context
44
import androidx.test.core.app.ApplicationProvider
@@ -7,14 +7,12 @@ import org.junit.Assert
77
import org.junit.Test
88
import org.junit.runner.RunWith
99
import org.schabi.newpipe.R
10-
import org.schabi.newpipe.error.ErrorInfo
11-
import org.schabi.newpipe.error.UserAction
1210
import org.schabi.newpipe.extractor.exceptions.ReCaptchaException
1311
import java.io.IOException
1412
import java.net.SocketTimeoutException
1513

1614
@RunWith(AndroidJUnit4::class)
17-
class CommentSectionErrorTest {
15+
class ErrorInfoCommentsTest {
1816
private val context: Context by lazy { ApplicationProvider.getApplicationContext<Context>() }
1917
// Test 1: Network error on initial load (Resource.Error)
2018
@Test

‎app/src/main/java/org/schabi/newpipe/ui/components/video/comment/CommentSection.kt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import androidx.compose.runtime.getValue
1616
import androidx.compose.ui.Alignment
1717
import androidx.compose.ui.Modifier
1818
import androidx.compose.ui.input.nestedscroll.nestedScroll
19-
import androidx.compose.ui.platform.LocalContext
2019
import androidx.compose.ui.platform.rememberNestedScrollInteropConnection
2120
import androidx.compose.ui.res.pluralStringResource
2221
import androidx.compose.ui.tooling.preview.Preview
@@ -57,7 +56,6 @@ private fun CommentSection(
5756
val comments = commentsFlow.collectAsLazyPagingItems()
5857
val nestedScrollInterop = rememberNestedScrollInteropConnection()
5958
val state = rememberLazyListState()
60-
val context = LocalContext.current
6159

6260
LazyColumnThemedScrollbar(state = state) {
6361
LazyColumn(

‎app/src/main/res/layout/fragment_video_detail.xml‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -214,15 +214,6 @@
214214
android:layout_marginTop="@dimen/video_item_detail_error_panel_margin"
215215
android:visibility="gone"
216216
tools:visibility="gone" />
217-
<androidx.compose.ui.platform.ComposeView
218-
android:id="@+id/compose_error_panel"
219-
android:layout_width="match_parent"
220-
android:layout_height="wrap_content"
221-
android:layout_below="@id/detail_title_root_layout"
222-
android:layout_marginTop="@dimen/video_item_detail_error_panel_margin"
223-
android:visibility="gone"
224-
/>
225-
226217
<!--HIDING ROOT-->
227218
<LinearLayout
228219
android:id="@+id/detail_content_root_hiding"

‎build_all.log‎

Lines changed: 199 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,199 @@
1+
WARNING: We recommend using a newer Android Gradle plugin to use compileSdk = 36
2+
3+
This Android Gradle plugin (8.7.1) was tested up to compileSdk = 35.
4+
5+
You are strongly encouraged to update your project to use a newer
6+
Android Gradle plugin that has been tested with compileSdk = 36.
7+
8+
If you are already using the latest version of the Android Gradle plugin,
9+
you may need to wait until a newer version with support for compileSdk = 36 is available.
10+
11+
For more information refer to the compatibility table:
12+
https://d.android.com/r/tools/api-level-support
13+
14+
To suppress this warning, add/update
15+
android.suppressUnsupportedCompileSdk=36
16+
to this project's gradle.properties.
17+
> Task :app:checkDependenciesOrder
18+
> Task :app:preBuild UP-TO-DATE
19+
> Task :app:runKtlint
20+
> Task :app:checkKotlinGradlePluginConfigurationErrors SKIPPED
21+
> Task :app:collectDependencies UP-TO-DATE
22+
> Task :app:prepareLibraryDefinitionsDebug UP-TO-DATE
23+
> Task :app:preDebugAndroidTestBuild SKIPPED
24+
> Task :app:generateDebugAndroidTestResValues UP-TO-DATE
25+
> Task :app:extractProguardFiles UP-TO-DATE
26+
> Task :app:preDebugUnitTestBuild UP-TO-DATE
27+
> Task :app:javaPreCompileDebugUnitTest UP-TO-DATE
28+
> Task :app:dataBindingMergeDependencyArtifactsDebugAndroidTest UP-TO-DATE
29+
> Task :app:generateDebugAndroidTestResources UP-TO-DATE
30+
> Task :app:mergeDebugAndroidTestResources UP-TO-DATE
31+
> Task :app:dataBindingGenBaseClassesDebugAndroidTest UP-TO-DATE
32+
> Task :app:processDebugAndroidTestManifest UP-TO-DATE
33+
> Task :app:generateDebugAndroidTestBuildConfig UP-TO-DATE
34+
> Task :app:checkDebugAndroidTestAarMetadata UP-TO-DATE
35+
> Task :app:mapDebugAndroidTestSourceSetPaths UP-TO-DATE
36+
> Task :app:processDebugAndroidTestResources UP-TO-DATE
37+
> Task :app:javaPreCompileDebugAndroidTest UP-TO-DATE
38+
> Task :app:mergeDebugAndroidTestShaders UP-TO-DATE
39+
> Task :app:compileDebugAndroidTestShaders NO-SOURCE
40+
> Task :app:generateDebugAndroidTestAssets UP-TO-DATE
41+
> Task :app:mergeDebugAndroidTestAssets UP-TO-DATE
42+
> Task :app:compressDebugAndroidTestAssets UP-TO-DATE
43+
> Task :app:desugarDebugAndroidTestFileDependencies UP-TO-DATE
44+
> Task :app:checkDebugAndroidTestDuplicateClasses UP-TO-DATE
45+
> Task :app:mergeExtDexDebugAndroidTest UP-TO-DATE
46+
> Task :app:mergeLibDexDebugAndroidTest UP-TO-DATE
47+
> Task :app:mergeDebugAndroidTestJniLibFolders UP-TO-DATE
48+
> Task :app:validateSigningDebugAndroidTest UP-TO-DATE
49+
> Task :app:writeDebugAndroidTestSigningConfigVersions UP-TO-DATE
50+
> Task :app:runCheckstyle
51+
> Task :app:preDebugBuild
52+
> Task :app:mergeDebugNativeDebugMetadata NO-SOURCE
53+
> Task :app:dataBindingMergeDependencyArtifactsDebug UP-TO-DATE
54+
> Task :app:generateDebugResValues UP-TO-DATE
55+
> Task :app:extractDebugSupportedLocales UP-TO-DATE
56+
> Task :app:generateDebugLocaleConfig UP-TO-DATE
57+
> Task :app:generateDebugResources UP-TO-DATE
58+
> Task :app:mergeDebugResources UP-TO-DATE
59+
> Task :app:packageDebugResources UP-TO-DATE
60+
> Task :app:parseDebugLocalResources UP-TO-DATE
61+
> Task :app:dataBindingGenBaseClassesDebug UP-TO-DATE
62+
> Task :app:generateDebugBuildConfig UP-TO-DATE
63+
> Task :app:checkDebugAarMetadata UP-TO-DATE
64+
> Task :app:mapDebugSourceSetPaths UP-TO-DATE
65+
> Task :app:createDebugCompatibleScreenManifests UP-TO-DATE
66+
> Task :app:extractDeepLinksDebug UP-TO-DATE
67+
68+
> Task :app:processDebugMainManifest
69+
/Users/sutt/StudioProjects/NewPipe/app/src/debug/AndroidManifest.xml Warning:
70+
provider#org.acra.attachment.AcraContentProvider@android:authorities was tagged at AndroidManifest.xml:0 to replace other declarations but no other declaration present
71+
72+
> Task :app:processDebugManifest
73+
> Task :app:javaPreCompileDebug UP-TO-DATE
74+
> Task :app:mergeDebugShaders UP-TO-DATE
75+
> Task :app:compileDebugShaders NO-SOURCE
76+
> Task :app:generateDebugAssets UP-TO-DATE
77+
> Task :app:mergeDebugAssets UP-TO-DATE
78+
> Task :app:compressDebugAssets UP-TO-DATE
79+
> Task :app:desugarDebugFileDependencies
80+
> Task :app:checkDebugDuplicateClasses UP-TO-DATE
81+
> Task :app:processDebugManifestForPackage
82+
> Task :app:mergeDebugJniLibFolders UP-TO-DATE
83+
> Task :app:mergeLibDexDebug
84+
> Task :app:mergeDebugNativeLibs UP-TO-DATE
85+
> Task :app:stripDebugDebugSymbols UP-TO-DATE
86+
> Task :app:validateSigningDebug UP-TO-DATE
87+
> Task :app:writeDebugAppMetadata UP-TO-DATE
88+
> Task :app:writeDebugSigningConfigVersions
89+
> Task :app:mergeDebugAndroidTestNativeLibs NO-SOURCE
90+
> Task :app:stripDebugAndroidTestDebugSymbols NO-SOURCE
91+
warn: removing resource org.schabi.newpipe.debug.CreateCommentSectionErrorPanel:string/show_image_indicators_summary without required default value.
92+
warn: removing resource org.schabi.newpipe.debug.CreateCommentSectionErrorPanel:string/show_image_indicators_title without required default value.
93+
94+
> Task :app:processDebugResources
95+
> Task :app:l8DexDesugarLibDebug
96+
> Task :app:mergeExtDexDebug
97+
98+
> Task :app:kaptGenerateStubsDebugKotlin
99+
w: Kapt currently doesn't support language version 2.0+. Falling back to 1.9.
100+
101+
> Task :app:kaptDebugKotlin
102+
103+
> Task :app:compileDebugKotlin
104+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/App.kt:207:21 Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type 'java.lang.Thread.UncaughtExceptionHandler?'.
105+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/error/ErrorPanelHelper.kt:74:26 'fun startActivityForResult(p0: Intent, p1: Int): Unit' is deprecated. Deprecated in Java.
106+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:354:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
107+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:355:15 'fun onActivityResult(p0: Int, p1: Int, p2: Intent?): Unit' is deprecated. Deprecated in Java.
108+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1786:35 'var systemUiVisibility: Int' is deprecated. Deprecated in Java.
109+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1787:63 'static field FLAG_FULLSCREEN: Int' is deprecated. Deprecated in Java.
110+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1788:25 'var statusBarColor: Int' is deprecated. Deprecated in Java.
111+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1808:18 'static field SYSTEM_UI_FLAG_LAYOUT_STABLE: Int' is deprecated. Deprecated in Java.
112+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1809:25 'static field SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN: Int' is deprecated. Deprecated in Java.
113+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1810:25 'static field SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION: Int' is deprecated. Deprecated in Java.
114+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1811:25 'static field SYSTEM_UI_FLAG_HIDE_NAVIGATION: Int' is deprecated. Deprecated in Java.
115+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1812:25 'static field SYSTEM_UI_FLAG_IMMERSIVE_STICKY: Int' is deprecated. Deprecated in Java.
116+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1819:45 'static field SYSTEM_UI_FLAG_FULLSCREEN: Int' is deprecated. Deprecated in Java.
117+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1821:35 'var systemUiVisibility: Int' is deprecated. Deprecated in Java.
118+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1824:29 'var statusBarColor: Int' is deprecated. Deprecated in Java.
119+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1825:29 'var navigationBarColor: Int' is deprecated. Deprecated in Java.
120+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt:1827:63 'static field FLAG_FULLSCREEN: Int' is deprecated. Deprecated in Java.
121+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt:110:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
122+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt:209:15 'fun onCreateOptionsMenu(p0: Menu, p1: MenuInflater): Unit' is deprecated. Deprecated in Java.
123+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt:244:22 'fun onOptionsItemSelected(p0: MenuItem): Boolean' is deprecated. Deprecated in Java.
124+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt:276:15 'fun onDestroyOptionsMenu(): Unit' is deprecated. Deprecated in Java.
125+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionFragment.kt:94:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
126+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionFragment.kt:132:15 'fun onCreateOptionsMenu(p0: Menu, p1: MenuInflater): Unit' is deprecated. Deprecated in Java.
127+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt:100:27 'fun onBackPressed(): Unit' is deprecated. Deprecated in Java.
128+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/export/ImportExportManager.kt:39:35 'val FILE_NAME_SERIALIZED_PREFS: String' is deprecated. Serializing preferences with Java's ObjectOutputStream is vulnerable to injections.
129+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/export/ImportExportManager.kt:93:69 'val FILE_NAME_SERIALIZED_PREFS: String' is deprecated. Serializing preferences with Java's ObjectOutputStream is vulnerable to injections.
130+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/export/ImportExportManager.kt:109:65 'val FILE_NAME_SERIALIZED_PREFS: String' is deprecated. Serializing preferences with Java's ObjectOutputStream is vulnerable to injections.
131+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/export/ImportExportManager.kt:138:63 'val FILE_NAME_SERIALIZED_PREFS: String' is deprecated. Serializing preferences with Java's ObjectOutputStream is vulnerable to injections.
132+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/notifications/NotificationModeConfigFragment.kt:42:9 'fun setHasOptionsMenu(p0: Boolean): Unit' is deprecated. Deprecated in Java.
133+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/notifications/NotificationModeConfigFragment.kt:82:15 'fun onCreateOptionsMenu(p0: Menu, p1: MenuInflater): Unit' is deprecated. Deprecated in Java.
134+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/settings/notifications/NotificationModeConfigFragment.kt:93:27 'fun onOptionsItemSelected(p0: MenuItem): Boolean' is deprecated. Deprecated in Java.
135+
w: file:///Users/sutt/StudioProjects/NewPipe/app/src/main/java/org/schabi/newpipe/ui/Toolbar.kt:83:13 'fun SearchBar(query: String, onQueryChange: (String) -> Unit, onSearch: (String) -> Unit, active: Boolean, onActiveChange: (Boolean) -> Unit, modifier: Modifier = ..., enabled: Boolean = ..., placeholder: @Composable() ComposableFunction0<Unit>? = ..., leadingIcon: @Composable() ComposableFunction0<Unit>? = ..., trailingIcon: @Composable() ComposableFunction0<Unit>? = ..., shape: Shape = ..., colors: SearchBarColors = ..., tonalElevation: Dp = ..., shadowElevation: Dp = ..., windowInsets: WindowInsets = ..., interactionSource: MutableInteractionSource? = ..., content: @Composable() ComposableFunction1<ColumnScope, Unit>): Unit' is deprecated. Use overload which takes inputField as a parameter.
136+
137+
> Task :app:compileDebugJavaWithJavac
138+
139+
> Task :app:hiltAggregateDepsDebug UP-TO-DATE
140+
> Task :app:hiltJavaCompileDebug
141+
> Task :app:processDebugJavaRes UP-TO-DATE
142+
> Task :app:mergeDebugJavaResource UP-TO-DATE
143+
> Task :app:bundleDebugClassesToCompileJar UP-TO-DATE
144+
> Task :app:generateDebugAndroidTestLintModel UP-TO-DATE
145+
> Task :app:generateDebugLintReportModel UP-TO-DATE
146+
> Task :app:generateDebugUnitTestLintModel UP-TO-DATE
147+
> Task :app:lintAnalyzeDebug UP-TO-DATE
148+
> Task :app:lintAnalyzeDebugAndroidTest UP-TO-DATE
149+
> Task :app:lintAnalyzeDebugUnitTest UP-TO-DATE
150+
> Task :app:lintReportDebug UP-TO-DATE
151+
> Task :app:lintDebug
152+
> Task :app:kaptGenerateStubsDebugUnitTestKotlin UP-TO-DATE
153+
> Task :app:kaptDebugUnitTestKotlin UP-TO-DATE
154+
> Task :app:compileDebugUnitTestKotlin UP-TO-DATE
155+
> Task :app:transformDebugClassesWithAsm
156+
> Task :app:compileDebugUnitTestJavaWithJavac UP-TO-DATE
157+
> Task :app:dexBuilderDebug
158+
> Task :app:mergeDebugGlobalSynthetics
159+
> Task :app:bundleDebugClassesToRuntimeJar UP-TO-DATE
160+
> Task :app:kaptGenerateStubsDebugAndroidTestKotlin UP-TO-DATE
161+
> Task :app:hiltAggregateDepsDebugUnitTest UP-TO-DATE
162+
> Task :app:hiltJavaCompileDebugUnitTest NO-SOURCE
163+
> Task :app:processDebugUnitTestJavaRes UP-TO-DATE
164+
> Task :app:transformDebugUnitTestClassesWithAsm UP-TO-DATE
165+
> Task :app:testDebugUnitTest UP-TO-DATE
166+
> Task :app:kaptDebugAndroidTestKotlin UP-TO-DATE
167+
> Task :app:mergeProjectDexDebug
168+
> Task :app:compileDebugAndroidTestKotlin UP-TO-DATE
169+
> Task :app:compileDebugAndroidTestJavaWithJavac UP-TO-DATE
170+
> Task :app:hiltAggregateDepsDebugAndroidTest UP-TO-DATE
171+
> Task :app:hiltJavaCompileDebugAndroidTest NO-SOURCE
172+
> Task :app:transformDebugAndroidTestClassesWithAsm UP-TO-DATE
173+
> Task :app:dexBuilderDebugAndroidTest UP-TO-DATE
174+
> Task :app:mergeDebugAndroidTestGlobalSynthetics UP-TO-DATE
175+
> Task :app:processDebugAndroidTestJavaRes UP-TO-DATE
176+
> Task :app:mergeDebugAndroidTestJavaResource UP-TO-DATE
177+
> Task :app:mergeProjectDexDebugAndroidTest UP-TO-DATE
178+
> Task :app:packageDebugAndroidTest UP-TO-DATE
179+
> Task :app:createDebugAndroidTestApkListingFileRedirect UP-TO-DATE
180+
> Task :app:packageDebug
181+
> Task :app:createDebugApkListingFileRedirect
182+
> Task :app:assembleDebug
183+
184+
> Task :app:connectedDebugAndroidTest
185+
Starting 28 tests on Pixel_9_Pro(AVD) - 16
186+
187+
Finished 28 tests on Pixel_9_Pro(AVD) - 16
188+
189+
> Task :app:connectedAndroidTest
190+
> Task :app:connectedCheck
191+
192+
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
193+
194+
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
195+
196+
For more on this, please refer to https://docs.gradle.org/8.9/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
197+
198+
BUILD SUCCESSFUL in 47s
199+
107 actionable tasks: 25 executed, 82 up-to-date

0 commit comments

Comments
 (0)