Player/handleIntent: call handleIntentPost unconditionally

We always need to handleIntentPost otherwise the VideoDetailFragment
is not setup correctly.

Author: Profpatsch

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -375,7 +375,6 @@ public void handleIntent(@NonNull final Intent intent) {
             }
         }
 
-        final PlayerType oldPlayerType = playerType;
         playerType = newPlayerType;
         initUIsForCurrentPlayerType();
         // TODO: what does the following comment mean? Is that a relict?
@@ -461,8 +460,6 @@ public void handleIntent(@NonNull final Intent intent) {
                                 initPlayback(newPlayQueue, playWhenReady);
                             }
 
-                            handleIntentPost(oldPlayerType);
-
                         }, throwable -> {
                             final var errorInfo = new ErrorInfo(throwable, UserAction.PLAY_ON_POPUP,
                                     dat.getUrl());
@@ -564,11 +561,10 @@ public void handleIntent(@NonNull final Intent intent) {
             initPlayback(samePlayQueue ? playQueue : newQueue, playWhenReady);
         }
 
-        handleIntentPost(oldPlayerType);
     }
 
 
-    private void handleIntentPost(final PlayerType oldPlayerType) {
+    public void handleIntentPost(final PlayerType oldPlayerType) {
         if (oldPlayerType != playerType && playQueue != null) {
             // If playerType changes from one to another we should reload the player
             // (to disable/enable video stream or to set quality)

app/src/main/java/org/schabi/newpipe/player/PlayerService.java

@@ -169,7 +169,9 @@ public int onStartCommand(final Intent intent, final int flags, final int startI
         }
 
         if (player != null) {
+            final PlayerType oldPlayerType = player.getPlayerType();
             player.handleIntent(intent);
+            player.handleIntentPost(oldPlayerType);
             player.UIs().get(MediaSessionPlayerUi.class)
                     .ifPresent(ui -> ui.handleMediaButtonIntent(intent));
         }