Skip to content

Commit 82de35d

Browse files
committed
Use view binding inside PreferenceViewHolder
1 parent f55e8ea commit 82de35d

1 file changed

Lines changed: 19 additions & 23 deletions

File tree

app/src/main/java/org/schabi/newpipe/settings/preferencesearch/PreferenceSearchAdapter.java

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,11 @@
44
import android.view.LayoutInflater;
55
import android.view.View;
66
import android.view.ViewGroup;
7-
import android.widget.TextView;
87

98
import androidx.annotation.NonNull;
109
import androidx.recyclerview.widget.RecyclerView;
1110

12-
import org.schabi.newpipe.R;
11+
import org.schabi.newpipe.databinding.SettingsPreferencesearchListItemResultBinding;
1312

1413
import java.util.ArrayList;
1514
import java.util.List;
@@ -22,37 +21,38 @@ class PreferenceSearchAdapter
2221

2322
@NonNull
2423
@Override
25-
public PreferenceSearchAdapter.PreferenceViewHolder onCreateViewHolder(
24+
public PreferenceViewHolder onCreateViewHolder(
2625
@NonNull final ViewGroup parent,
2726
final int viewType
2827
) {
2928
return new PreferenceViewHolder(
30-
LayoutInflater
31-
.from(parent.getContext())
32-
.inflate(R.layout.settings_preferencesearch_list_item_result, parent, false));
29+
SettingsPreferencesearchListItemResultBinding.inflate(
30+
LayoutInflater.from(parent.getContext()),
31+
parent,
32+
false));
3333
}
3434

3535
@Override
3636
public void onBindViewHolder(
37-
@NonNull final PreferenceSearchAdapter.PreferenceViewHolder holder,
37+
@NonNull final PreferenceViewHolder holder,
3838
final int position
3939
) {
4040
final PreferenceSearchItem item = dataset.get(position);
4141

42-
holder.title.setText(item.getTitle());
42+
holder.binding.title.setText(item.getTitle());
4343

4444
if (TextUtils.isEmpty(item.getSummary())) {
45-
holder.summary.setVisibility(View.GONE);
45+
holder.binding.summary.setVisibility(View.GONE);
4646
} else {
47-
holder.summary.setVisibility(View.VISIBLE);
48-
holder.summary.setText(item.getSummary());
47+
holder.binding.summary.setVisibility(View.VISIBLE);
48+
holder.binding.summary.setText(item.getSummary());
4949
}
5050

5151
if (TextUtils.isEmpty(item.getBreadcrumbs())) {
52-
holder.breadcrumbs.setVisibility(View.GONE);
52+
holder.binding.breadcrumbs.setVisibility(View.GONE);
5353
} else {
54-
holder.breadcrumbs.setVisibility(View.VISIBLE);
55-
holder.breadcrumbs.setText(item.getBreadcrumbs());
54+
holder.binding.breadcrumbs.setVisibility(View.VISIBLE);
55+
holder.binding.breadcrumbs.setText(item.getBreadcrumbs());
5656
}
5757

5858
holder.itemView.setOnClickListener(v -> {
@@ -77,15 +77,11 @@ void setOnItemClickListener(final Consumer<PreferenceSearchItem> onItemClickList
7777
}
7878

7979
static class PreferenceViewHolder extends RecyclerView.ViewHolder {
80-
final TextView title;
81-
final TextView summary;
82-
final TextView breadcrumbs;
83-
84-
PreferenceViewHolder(final View v) {
85-
super(v);
86-
title = v.findViewById(R.id.title);
87-
summary = v.findViewById(R.id.summary);
88-
breadcrumbs = v.findViewById(R.id.breadcrumbs);
80+
final SettingsPreferencesearchListItemResultBinding binding;
81+
82+
PreferenceViewHolder(final SettingsPreferencesearchListItemResultBinding binding) {
83+
super(binding.getRoot());
84+
this.binding = binding;
8985
}
9086
}
9187
}

0 commit comments

Comments
 (0)