tackle review issues

Author: Idadelveloper

app/src/main/java/org/schabi/newpipe/error/ErrorReportHelper.kt

@@ -48,8 +48,8 @@ object ErrorReportHelper {
                 .value("user_comment", comment)
                 .end()
                 .done()
-        } catch (e: Exception) {
-            Log.e(TAG, "Could not build json", e)
+        } catch (exception: Exception) {
+            Log.e(TAG, "Could not build json", exception)
         }
         return ""
     }
@@ -95,8 +95,8 @@ object ErrorReportHelper {
 
                 append("<hr>\n")
             }
-        } catch (e: Exception) {
-            Log.e(TAG, "Could not build markdown", e)
+        } catch (exception: Exception) {
+            Log.e(TAG, "Could not build markdown", exception)
             return ""
         }
     }

app/src/main/java/org/schabi/newpipe/navigation/NavDisplay.kt

@@ -5,7 +5,6 @@
 
 package org.schabi.newpipe.navigation
 
-import android.content.Intent
 import androidx.activity.compose.LocalActivity
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
@@ -20,7 +19,6 @@ import androidx.navigation3.runtime.rememberNavBackStack
 import androidx.navigation3.runtime.rememberSaveableStateHolderNavEntryDecorator
 import androidx.navigation3.ui.NavDisplay
 import org.schabi.newpipe.ComposeActivity
-import org.schabi.newpipe.MainActivity
 import org.schabi.newpipe.R
 import org.schabi.newpipe.error.ErrorInfo
 import org.schabi.newpipe.error.ErrorReportHelper
@@ -45,18 +43,7 @@ fun NavDisplay(startDestination: NavKey) {
         if (backstack.size > 1) {
             backstack.removeLastOrNull()
         } else {
-            // If this is the last screen in the backstack and there's no parent task,
-            // navigate to MainActivity so the user lands on the home screen.
-            activity?.let {
-                if (it.isTaskRoot) {
-                    it.startActivity(
-                        Intent(it, MainActivity::class.java).apply {
-                            addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP)
-                        }
-                    )
-                }
-                it.finish()
-            }
+            activity?.finish()
         }
     }
 

app/src/main/java/org/schabi/newpipe/ui/screens/ErrorReportScreen.kt

@@ -48,6 +48,9 @@ import org.schabi.newpipe.ui.components.common.ScaffoldWithToolbar
 import org.schabi.newpipe.ui.theme.AppTheme
 import org.schabi.newpipe.util.Localization
 
+private const val ACTION_EMAIL = "EMAIL"
+private const val ACTION_GITHUB = "GITHUB"
+
 sealed interface ErrorReportEvent {
     data class ReportViaEmail(val comment: String) : ErrorReportEvent
     data class CopyForGitHub(val comment: String) : ErrorReportEvent
@@ -73,9 +76,6 @@ fun ErrorReportScreen(
     )
 }
 
-private const val ACTION_EMAIL = "EMAIL"
-private const val ACTION_GITHUB = "GITHUB"
-
 @Composable
 private fun ErrorReportContent(
     errorMessage: String,