Skip to content

Commit 70e0085

Browse files
committed
Converted placeholders to svg
* Required for SubscriptionFragment (otherwise the PopUp-menu uses half of the screen) * Size reduction * Fixed/Improved some images: * Bandcamp: Was facing in the wrong direction and used an incorrect logo * Media CCC: Update logo * YT: Added NewPipe logo so that it's not just a rectangle
1 parent f9ccc19 commit 70e0085

16 files changed

Lines changed: 69 additions & 10 deletions

app/src/main/java/org/schabi/newpipe/settings/PeertubeInstanceListFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ private void showAddItemDialog(final Context c) {
207207

208208
new AlertDialog.Builder(c)
209209
.setTitle(R.string.peertube_instance_add_title)
210-
.setIcon(R.drawable.place_holder_peertube)
210+
.setIcon(R.drawable.ic_placeholder_peertube)
211211
.setView(dialogBinding.getRoot())
212212
.setNegativeButton(R.string.cancel, null)
213213
.setPositiveButton(R.string.ok, (dialog1, which) -> {
@@ -411,7 +411,7 @@ void bind(final int position, final TabViewHolder holder) {
411411
lastChecked = instanceRB;
412412
}
413413
});
414-
instanceIconView.setImageResource(R.drawable.place_holder_peertube);
414+
instanceIconView.setImageResource(R.drawable.ic_placeholder_peertube);
415415
}
416416

417417
@SuppressLint("ClickableViewAccessibility")

app/src/main/java/org/schabi/newpipe/util/ServiceHelper.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ private ServiceHelper() { }
3131
public static int getIcon(final int serviceId) {
3232
switch (serviceId) {
3333
case 0:
34-
return R.drawable.place_holder_youtube;
34+
return R.drawable.ic_placeholder_yt;
3535
case 1:
36-
return R.drawable.place_holder_cloud;
36+
return R.drawable.ic_placeholder_cloud;
3737
case 2:
38-
return R.drawable.place_holder_gadse;
38+
return R.drawable.ic_placeholder_media_ccc;
3939
case 3:
40-
return R.drawable.place_holder_peertube;
40+
return R.drawable.ic_placeholder_peertube;
4141
case 4:
42-
return R.drawable.place_holder_bandcamp;
42+
return R.drawable.ic_placeholder_bandcamp;
4343
default:
44-
return R.drawable.place_holder_circle;
44+
return R.drawable.ic_placeholder_circle;
4545
}
4646
}
4747

-2.61 KB
Binary file not shown.
-5.2 KB
Binary file not shown.
-3.57 KB
Binary file not shown.
-8.62 KB
Binary file not shown.
-8.14 KB
Binary file not shown.
-1.7 KB
Binary file not shown.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:height="24dp"
3+
android:width="24dp"
4+
android:viewportHeight="97.75"
5+
android:viewportWidth="97.75"
6+
android:tint="@color/defaultIconTint">
7+
<path
8+
android:pathData="M48.875,0C21.882,0 0,21.882 0,48.875S21.882,97.75 48.875,97.75 97.75,75.868 97.75,48.875 75.868,0 48.875,0zM64.835,70.857L12.593,70.857l20.32,-43.965h52.244L64.835,70.857z"
9+
android:fillColor="#FF000000" />
10+
</vector>
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:height="24dp"
3+
android:width="24dp"
4+
android:viewportHeight="24"
5+
android:viewportWidth="24"
6+
android:tint="@color/defaultIconTint" >
7+
<path
8+
android:pathData="M12,2C6.48,2 2,6.48 2,12s4.48,10 10,10s10,-4.49 10,-10S17.52,2 12,2L12,2z"
9+
android:fillColor="#FF000000" />
10+
</vector>

0 commit comments

Comments
 (0)