Add missing permission checks for notifications

Notifications can be disabled manually even after permission has been granted once.
Always check if they are enabled before notifying the user.

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>

Author: theimpulson

app/src/main/java/org/schabi/newpipe/NewVersionWorker.kt

@@ -82,7 +82,9 @@ class NewVersionWorker(
             )
 
         val notificationManager = NotificationManagerCompat.from(applicationContext)
-        notificationManager.notify(2000, notificationBuilder.build())
+        if (notificationManager.areNotificationsEnabled()) {
+            notificationManager.notify(2000, notificationBuilder.build())
+        }
     }
 
     @Throws(IOException::class, ReCaptchaException::class)

app/src/main/java/org/schabi/newpipe/error/ErrorUtil.kt

@@ -134,8 +134,11 @@ class ErrorUtil {
                         )
                     )
 
-            NotificationManagerCompat.from(context)
-                .notify(ERROR_REPORT_NOTIFICATION_ID, notificationBuilder.build())
+            val notificationManager = NotificationManagerCompat.from(context)
+            if (notificationManager.areNotificationsEnabled()) {
+                notificationManager
+                    .notify(ERROR_REPORT_NOTIFICATION_ID, notificationBuilder.build())
+            }
 
             ContextCompat.getMainExecutor(context).execute {
                 // since the notification is silent, also show a toast, otherwise the user is confused

app/src/main/java/org/schabi/newpipe/local/feed/notifications/NotificationHelper.kt

@@ -92,17 +92,21 @@ class NotificationHelper(val context: Context) {
                 // Show individual stream notifications, set channel icon only if there is actually
                 // one
                 showStreamNotifications(newStreams, data.serviceId, data.url, bitmap)
-                // Show summary notification
-                manager.notify(data.pseudoId, summaryBuilder.build())
+                // Show summary notification if enabled
+                if (manager.areNotificationsEnabled()) {
+                    manager.notify(data.pseudoId, summaryBuilder.build())
+                }
 
                 iconLoadingTargets.remove(this) // allow it to be garbage-collected
             }
 
             override fun onBitmapFailed(e: Exception, errorDrawable: Drawable) {
                 // Show individual stream notifications
                 showStreamNotifications(newStreams, data.serviceId, data.url, null)
-                // Show summary notification
-                manager.notify(data.pseudoId, summaryBuilder.build())
+                // Show summary notification if enabled
+                if (manager.areNotificationsEnabled()) {
+                    manager.notify(data.pseudoId, summaryBuilder.build())
+                }
                 iconLoadingTargets.remove(this) // allow it to be garbage-collected
             }
 
@@ -124,9 +128,12 @@ class NotificationHelper(val context: Context) {
         channelUrl: String,
         channelIcon: Bitmap?
     ) {
-        for (stream in newStreams) {
-            val notification = createStreamNotification(stream, serviceId, channelUrl, channelIcon)
-            manager.notify(stream.url.hashCode(), notification)
+        if (manager.areNotificationsEnabled()) {
+            newStreams.forEach { stream ->
+                val notification =
+                    createStreamNotification(stream, serviceId, channelUrl, channelIcon)
+                manager.notify(stream.url.hashCode(), notification)
+            }
         }
     }
 

app/src/main/java/org/schabi/newpipe/local/feed/service/FeedLoadService.kt

@@ -185,7 +185,9 @@ class FeedLoadService : Service() {
             }
         }
 
-        notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build())
+        if (notificationManager.areNotificationsEnabled()) {
+            notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build())
+        }
     }
 
     // /////////////////////////////////////////////////////////////////////////

app/src/main/java/org/schabi/newpipe/local/subscription/services/BaseImportExportService.java

@@ -144,7 +144,9 @@ protected void updateNotification(final String text) {
             notificationBuilder.setContentText(text);
         }
 
-        notificationManager.notify(getNotificationId(), notificationBuilder.build());
+        if (notificationManager.areNotificationsEnabled()) {
+            notificationManager.notify(getNotificationId(), notificationBuilder.build());
+        }
     }
 
     protected void stopService() {
@@ -174,7 +176,10 @@ protected void postErrorResult(final String title, final String text) {
                 .setContentTitle(title)
                 .setStyle(new NotificationCompat.BigTextStyle().bigText(textOrEmpty))
                 .setContentText(textOrEmpty);
-        notificationManager.notify(getNotificationId(), notificationBuilder.build());
+
+        if (notificationManager.areNotificationsEnabled()) {
+            notificationManager.notify(getNotificationId(), notificationBuilder.build());
+        }
     }
 
     protected NotificationCompat.Builder createNotification() {

app/src/main/java/org/schabi/newpipe/player/notification/NotificationUtil.java

@@ -72,7 +72,9 @@ public synchronized void createNotificationIfNeededAndUpdate(final boolean force
             notificationBuilder = createNotification();
         }
         updateNotification();
-        notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
+        if (notificationManager.areNotificationsEnabled()) {
+            notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
+        }
     }
 
     public synchronized void updateThumbnail() {
@@ -84,7 +86,9 @@ public synchronized void updateThumbnail() {
             }
 
             setLargeIcon(notificationBuilder);
-            notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
+            if (notificationManager.areNotificationsEnabled()) {
+                notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
+            }
         }
     }