Skip to content

Commit 640d4b0

Browse files
committed
Fix more NPEs after OnSharedPreferenceChangeListener changes
1 parent b9378a7 commit 640d4b0

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

app/src/main/java/org/schabi/newpipe/local/feed/FeedFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class FeedFragment : BaseStateFragment<FeedState>() {
122122
groupName = arguments?.getString(KEY_GROUP_NAME) ?: ""
123123

124124
onSettingsChangeListener = SharedPreferences.OnSharedPreferenceChangeListener { _, key ->
125-
if (key.equals(getString(R.string.list_view_mode_key))) {
125+
if (getString(R.string.list_view_mode_key).equals(key)) {
126126
updateListViewModeOnResume = true
127127
}
128128
}

app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettingsFragment.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ public void onCreatePreferences(final Bundle savedInstanceState, final String ro
2727

2828
updateSeekOptions();
2929

30-
listener = (sharedPreferences, s) -> {
30+
listener = (sharedPreferences, key) -> {
3131

3232
// on M and above, if user chooses to minimise to popup player on exit
3333
// and the app doesn't have display over other apps permission,
3434
// show a snackbar to let the user give permission
3535
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
36-
&& s.equals(getString(R.string.minimize_on_exit_key))) {
37-
final String newSetting = sharedPreferences.getString(s, null);
36+
&& getString(R.string.minimize_on_exit_key).equals(key)) {
37+
final String newSetting = sharedPreferences.getString(key, null);
3838
if (newSetting != null
3939
&& newSetting.equals(getString(R.string.minimize_on_exit_popup_key))
4040
&& !Settings.canDrawOverlays(getContext())) {
@@ -46,7 +46,7 @@ public void onCreatePreferences(final Bundle savedInstanceState, final String ro
4646
.show();
4747

4848
}
49-
} else if (s.equals(getString(R.string.use_inexact_seek_key))) {
49+
} else if (getString(R.string.use_inexact_seek_key).equals(key)) {
5050
updateSeekOptions();
5151
}
5252
};

0 commit comments

Comments
 (0)