Skip to content

Commit 571bf39

Browse files
authored
Merge pull request #8666 from TacoTheDank/filepicker
Update FilePicker to our custom fork and disable Jetifier
2 parents 74921d3 + baabba1 commit 571bf39

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

app/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ dependencies {
188188
// This works thanks to JitPack: https://jitpack.io/
189189
implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
190190
implementation 'com.github.TeamNewPipe:NewPipeExtractor:5219a705bab539cf8c6624d0cec216e76e85f0b1'
191+
implementation 'com.github.TeamNewPipe:NoNonsense-FilePicker:5.0.0'
191192

192193
/** Checkstyle **/
193194
checkstyle "com.puppycrawl.tools:checkstyle:${checkstyleVersion}"
@@ -257,9 +258,6 @@ dependencies {
257258
implementation "io.noties.markwon:core:${markwonVersion}"
258259
implementation "io.noties.markwon:linkify:${markwonVersion}"
259260

260-
// File picker
261-
implementation "com.nononsenseapps:filepicker:4.2.1"
262-
263261
// Crash reporting
264262
implementation "ch.acra:acra-core:5.9.3"
265263

app/src/main/java/org/schabi/newpipe/util/FilePickerActivityHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ protected AbstractFilePickerFragment<File> getFragment(@Nullable final String st
7676

7777
public static class CustomFilePickerFragment extends FilePickerFragment {
7878
@Override
79-
public View onCreateView(final LayoutInflater inflater, final ViewGroup container,
79+
public View onCreateView(@NonNull final LayoutInflater inflater, final ViewGroup container,
8080
final Bundle savedInstanceState) {
8181
return super.onCreateView(inflater, container, savedInstanceState);
8282
}
@@ -138,7 +138,7 @@ public boolean isBackTop() {
138138
}
139139

140140
@Override
141-
public void onLoadFinished(final Loader<SortedList<File>> loader,
141+
public void onLoadFinished(@NonNull final Loader<SortedList<File>> loader,
142142
final SortedList<File> data) {
143143
super.onLoadFinished(loader, data);
144144
layoutManager.scrollToPosition(0);

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
android.enableJetifier=true
1+
android.enableJetifier=false
22
android.useAndroidX=true
33
org.gradle.jvmargs=-Xmx2048M
44
systemProp.file.encoding=utf-8

0 commit comments

Comments
 (0)