searchfilters: remove onResume() onPause() calles

Those calles are no longer needed as the causing null ptr problem
was solved using the convertView paramter instead of locally cache
the TextView's in the Spinner Adapter.

Author: evermind-zz

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/BaseSearchFilterDialogFragment.java

@@ -109,19 +109,6 @@ public View onCreateView(@NonNull final LayoutInflater inflater,
         return rootView;
     }
 
-
-    @Override
-    public void onResume() {
-        super.onResume();
-        dialogGenerator.onResume();
-    }
-
-    @Override
-    public void onStop() {
-        dialogGenerator.onPause();
-        super.onStop();
-    }
-
     @Override
     public void onViewCreated(@NonNull final View view, final Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/BaseSearchFilterUiDialogGenerator.java

@@ -10,17 +10,13 @@
 import org.schabi.newpipe.extractor.linkhandler.SearchQueryHandlerFactory;
 import org.schabi.newpipe.extractor.search.filter.FilterGroup;
 
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 
 import static android.util.TypedValue.COMPLEX_UNIT_DIP;
 
 public abstract class BaseSearchFilterUiDialogGenerator extends BaseSearchFilterUiGenerator {
     private static final float FONT_SIZE_TITLE_ITEMS_IN_DIP = 20f;
 
-    protected final Map<View, View.OnClickListener> viewListeners = new HashMap<>();
-
     protected BaseSearchFilterUiDialogGenerator(
             final SearchQueryHandlerFactory linkHandlerFactory,
             final Callback callback,
@@ -44,20 +40,6 @@ protected ICreateUiForFiltersWorker createSortFilterWorker() {
         return new BaseCreateSearchFilterUI.CreateSortFilterUI(this, context);
     }
 
-    @Override
-    public void onResume() {
-        for (final Map.Entry<View, View.OnClickListener> view : viewListeners.entrySet()) {
-            view.getKey().setOnClickListener(view.getValue());
-        }
-    }
-
-    @Override
-    public void onPause() {
-        for (final Map.Entry<View, View.OnClickListener> view : viewListeners.entrySet()) {
-            view.getKey().setOnClickListener(null);
-        }
-    }
-
     protected View createSeparatorLine(final ViewGroup.LayoutParams layoutParams) {
         final View separatorLine = new View(context);
         separatorLine.setBackgroundColor(getSeparatorLineColorFromTheme());

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/BaseSearchFilterUiGenerator.java

@@ -66,18 +66,6 @@ protected void doMeasurementsIfNeeded() {
         // nothing to measure here, if you want to measure something override this method
     }
 
-    /**
-     * If UI is implemented within an fragment/activity this method has to be called from
-     * its corresponding lifecyle method manually.
-     */
-    public abstract void onResume();
-
-    /**
-     * If UI is implemented within an fragment/activity this method has to be called from
-     * its corresponding lifecyle method manually.
-     */
-    public abstract void onPause();
-
     /**
      * Helper interface used as 'function pointer'.
      */

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/SearchFilterDialogGenerator.java

@@ -21,15 +21,12 @@
 import org.schabi.newpipe.util.DeviceUtils;
 import org.schabi.newpipe.util.ServiceHelper;
 
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 
 import androidx.appcompat.view.ContextThemeWrapper;
 
 public class SearchFilterDialogGenerator extends BaseSearchFilterUiDialogGenerator {
     private final GridLayout globalLayout;
-    private final Map<Spinner, AdapterView.OnItemSelectedListener> spinners = new HashMap<>();
 
     public SearchFilterDialogGenerator(final StreamingService service,
                                        final ViewGroup root,
@@ -40,24 +37,6 @@ public SearchFilterDialogGenerator(final StreamingService service,
         root.addView(globalLayout);
     }
 
-    @Override
-    public void onResume() {
-        for (final Map.Entry<Spinner, AdapterView.OnItemSelectedListener> spinner
-                : spinners.entrySet()) {
-            spinner.getKey().setOnItemSelectedListener(spinner.getValue());
-        }
-        super.onResume();
-    }
-
-    @Override
-    public void onPause() {
-        for (final Map.Entry<Spinner, AdapterView.OnItemSelectedListener> spinner
-                : spinners.entrySet()) {
-            spinner.getKey().setOnItemSelectedListener(null);
-        }
-        super.onPause();
-    }
-
     @Override
     protected void createTitle(final String name,
                                final List<View> titleViewElements) {
@@ -156,7 +135,6 @@ public void onNothingSelected(final AdapterView<?> parent) {
         };
 
         filterDataSpinner.setOnItemSelectedListener(listener);
-        spinners.put(filterDataSpinner, listener);
     }
 
     private void createUiElementsForMultipleSelectableItemsFilterGroup(
@@ -175,7 +153,6 @@ private void createUiElementsForMultipleSelectableItemsFilterGroup(
 
             chip.setOnClickListener(listener);
             chipGroup.addView(chip);
-            viewListeners.put(chip, listener);
             wrapperDelegate.put(item.getIdentifier(), new UiItemWrapperChip(
                     item, chip, chipGroup));
         }

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/SearchFilterOptionMenuAlikeDialogGenerator.java

@@ -164,7 +164,6 @@ private void createUiElementsForSingleSelectableItemsFilterGroup(
                     }
                 };
                 view.setOnClickListener(listener);
-                viewListeners.put(view, listener);
             }
             radioGroup.addView(view);
         }
@@ -191,7 +190,6 @@ private void createUiElementsForMultipleSelectableItemsFilterGroup(
                     }
                 };
                 checkBox.setOnClickListener(listener);
-                viewListeners.put(checkBox, listener);
 
                 view = checkBox;
             }

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/SearchFilterUIOptionMenu.java

@@ -124,16 +124,6 @@ protected ICreateUiForFiltersWorker createContentFilterWorker() {
         return new CreateContentFilterUI();
     }
 
-    @Override
-    public void onResume() {
-        // Menu does not need a implementation here
-    }
-
-    @Override
-    public void onPause() {
-        // Menu does not need a implementation here
-    }
-
     private static class UiItemWrapper implements IUiItemWrapper {
 
         private final MenuItem item;

app/src/test/java/org/schabi/newpipe/filter/SearchFilterLogicAndUiGeneratorTest.java

@@ -428,14 +428,6 @@ protected ICreateUiForFiltersWorker createSortFilterWorker() {
         protected ICreateUiForFiltersWorker createContentFilterWorker() {
             return null;
         }
-
-        @Override
-        public void onResume() {
-        }
-
-        @Override
-        public void onPause() {
-        }
     }
 
     static class ElementsWrapper implements SearchFilterLogic.IUiItemWrapper {