Fix ordering of error messages conditions

Author: Stypox

app/src/main/java/org/schabi/newpipe/error/ErrorInfo.kt

@@ -104,6 +104,21 @@ class ErrorInfo(
             action: UserAction?
         ): Int {
             return when {
+                // player exceptions
+                // some may be IOException, so do these checks before isNetworkRelated!
+                throwable is ExoPlaybackException -> {
+                    val cause = throwable.cause
+                    when {
+                        cause is HttpDataSource.InvalidResponseCodeException && cause.responseCode == 403 -> R.string.player_error_403
+                        cause is Loader.UnexpectedLoaderException && cause.cause is ExtractionException -> getMessageStringId(throwable, action)
+                        throwable.type == ExoPlaybackException.TYPE_SOURCE -> R.string.player_stream_failure
+                        throwable.type == ExoPlaybackException.TYPE_UNEXPECTED -> R.string.player_recoverable_failure
+                        else -> R.string.player_unrecoverable_failure
+                    }
+                }
+                throwable is FailedMediaSource.FailedMediaSourceException -> getMessageStringId(throwable.cause, action)
+                throwable is PlaybackResolver.ResolverException -> R.string.player_stream_failure
+
                 // content not available exceptions
                 throwable is AccountTerminatedException -> R.string.account_terminated
                 throwable is AgeRestrictedContentException -> R.string.restricted_video_no_stream
@@ -116,30 +131,18 @@ class ErrorInfo(
                 throwable is YoutubeSignInConfirmNotBotException -> R.string.youtube_sign_in_confirm_not_bot_error
                 throwable is ContentNotAvailableException -> R.string.content_not_available
 
+                // other extractor exceptions
+                throwable is ContentNotSupportedException -> R.string.content_not_supported
                 // ReCaptchas should have already been handled elsewhere,
                 // but return an error message here just in case
                 throwable is ReCaptchaException -> R.string.recaptcha_request_toast
-
-                // other extractor exceptions
-                throwable is ContentNotSupportedException -> R.string.content_not_supported
+                // test this at the end as many exceptions could be a subclass of IOException
                 throwable != null && throwable.isNetworkRelated -> R.string.network_error
+                // an extraction exception unrelated to the network
+                // is likely an issue with parsing the website
                 throwable is ExtractionException -> R.string.parsing_error
 
-                // player exceptions
-                throwable is ExoPlaybackException -> {
-                    val cause = throwable.cause
-                    when {
-                        cause is HttpDataSource.InvalidResponseCodeException && cause.responseCode == 403 -> R.string.player_error_403
-                        cause is Loader.UnexpectedLoaderException && cause.cause is ExtractionException -> getMessageStringId(throwable, action)
-                        throwable.type == ExoPlaybackException.TYPE_SOURCE -> R.string.player_stream_failure
-                        throwable.type == ExoPlaybackException.TYPE_UNEXPECTED -> R.string.player_recoverable_failure
-                        else -> R.string.player_unrecoverable_failure
-                    }
-                }
-                throwable is FailedMediaSource.FailedMediaSourceException -> getMessageStringId(throwable.cause, action)
-                throwable is PlaybackResolver.ResolverException -> R.string.player_stream_failure
-
-                // user actions (in case the exception is unrecognizable)
+                // user actions (in case the exception is null or unrecognizable)
                 action == UserAction.UI_ERROR -> R.string.app_ui_crash
                 action == UserAction.REQUESTED_COMMENTS -> R.string.error_unable_to_load_comments
                 action == UserAction.SUBSCRIPTION_CHANGE -> R.string.subscription_change_failed