Skip to content

Commit 4903786

Browse files
authored
Merge pull request #9758 from Stypox/fix-api33-links-again
Fix opening links on Android 12+
2 parents c85af78 + 4cc653f commit 4903786

1 file changed

Lines changed: 8 additions & 11 deletions

File tree

  • app/src/main/java/org/schabi/newpipe/util/external_communication

app/src/main/java/org/schabi/newpipe/util/external_communication/ShareUtils.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -90,19 +90,16 @@ public static boolean openUrlInBrowser(@NonNull final Context context,
9090
// No browser set as default (doesn't work on some devices)
9191
openAppChooser(context, intent, true);
9292
} else {
93-
if (defaultPackageName.isEmpty()) {
94-
// No app installed to open a web url
95-
Toast.makeText(context, R.string.no_app_to_open_intent, Toast.LENGTH_LONG).show();
96-
return false;
97-
} else {
98-
try {
93+
try {
94+
// will be empty on Android 12+
95+
if (!defaultPackageName.isEmpty()) {
9996
intent.setPackage(defaultPackageName);
100-
context.startActivity(intent);
101-
} catch (final ActivityNotFoundException e) {
102-
// Not a browser but an app chooser because of OEMs changes
103-
intent.setPackage(null);
104-
openAppChooser(context, intent, true);
10597
}
98+
context.startActivity(intent);
99+
} catch (final ActivityNotFoundException e) {
100+
// Not a browser but an app chooser because of OEMs changes
101+
intent.setPackage(null);
102+
openAppChooser(context, intent, true);
106103
}
107104
}
108105

0 commit comments

Comments
 (0)