Skip to content

Commit 467dacd

Browse files
authored
Merge pull request #5217 from Isira-Seneviratne/Use_WebViewClientCompat
Use WebViewClientCompat.
2 parents 75e34a5 + 1731505 commit 467dacd

2 files changed

Lines changed: 3 additions & 17 deletions

File tree

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ dependencies {
203203
implementation 'androidx.core:core-ktx:1.3.2'
204204
implementation 'androidx.documentfile:documentfile:1.0.1'
205205
implementation 'androidx.localbroadcastmanager:localbroadcastmanager:1.0.0'
206+
implementation 'androidx.webkit:webkit:1.4.0'
206207

207208
implementation "androidx.lifecycle:lifecycle-livedata:${androidxLifecycleVersion}"
208209
implementation "androidx.lifecycle:lifecycle-viewmodel:${androidxLifecycleVersion}"

app/src/main/java/org/schabi/newpipe/ReCaptchaActivity.java

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,16 @@
88
import android.view.Menu;
99
import android.view.MenuItem;
1010
import android.webkit.CookieManager;
11-
import android.webkit.WebResourceRequest;
1211
import android.webkit.WebSettings;
1312
import android.webkit.WebView;
14-
import android.webkit.WebViewClient;
1513

1614
import androidx.annotation.NonNull;
1715
import androidx.annotation.Nullable;
18-
import androidx.annotation.RequiresApi;
1916
import androidx.appcompat.app.ActionBar;
2017
import androidx.appcompat.app.AppCompatActivity;
2118
import androidx.core.app.NavUtils;
2219
import androidx.preference.PreferenceManager;
20+
import androidx.webkit.WebViewClientCompat;
2321

2422
import org.schabi.newpipe.databinding.ActivityRecaptchaBinding;
2523
import org.schabi.newpipe.util.ThemeHelper;
@@ -83,20 +81,7 @@ protected void onCreate(final Bundle savedInstanceState) {
8381
webSettings.setJavaScriptEnabled(true);
8482
webSettings.setUserAgentString(DownloaderImpl.USER_AGENT);
8583

86-
recaptchaBinding.reCaptchaWebView.setWebViewClient(new WebViewClient() {
87-
@RequiresApi(api = Build.VERSION_CODES.LOLLIPOP)
88-
@Override
89-
public boolean shouldOverrideUrlLoading(final WebView view,
90-
final WebResourceRequest request) {
91-
final String url = request.getUrl().toString();
92-
if (MainActivity.DEBUG) {
93-
Log.d(TAG, "shouldOverrideUrlLoading: request.url=" + url);
94-
}
95-
96-
handleCookiesFromUrl(url);
97-
return false;
98-
}
99-
84+
recaptchaBinding.reCaptchaWebView.setWebViewClient(new WebViewClientCompat() {
10085
@Override
10186
public boolean shouldOverrideUrlLoading(final WebView view, final String url) {
10287
if (MainActivity.DEBUG) {

0 commit comments

Comments
 (0)