Update README with latest changes and features

Author: osphvdhwj

external-player/README.md

@@ -1,35 +1,29 @@
-# NewPipe External Player (feature/mx-like-external-player)
+# NewPipe External Player (feature/mx-like-external-player) — updated
 
-This module provides an ExoPlayer-based external video player which can be used as a system external player:
-- Accepts VIEW and SEND intents (http(s) links, text share).
-- Basic ExoPlayer integration with PlayerView and controls.
-- Picture-in-Picture (PiP) support (Android O+).
-- UI skeleton matching typical external players (MX-style quick controls).
+What's in this update:
+- Foreground PlayerService for background playback and persistent MediaStyle notification.
+- MediaSession integration so lockscreen/playback controls work.
+- Activity delegates playback to the service (better lifecycle behavior).
+- Playbook speed control (cycle speeds), subtitle toggle placeholder.
+- Updated manifest to request FOREGROUND_SERVICE permission.
 
-What is included in this branch:
-- external-player module with PlayerActivity, layout, and manifest intent filters.
-- build.gradle configured for ExoPlayer.
-
-Important notes / Limitations:
-- Direct YouTube links cannot be played directly by ExoPlayer; YouTube requires stream extraction. This branch includes placeholders and a TODO where the app should call the extractor already present in the main app (NewPipe's extractor) to produce playable stream URLs, or integrate a secure YouTube extraction pipeline.
-- DRM, subtitles, audio-only background service, casting, and advanced subtitle selection are not yet implemented in this initial commit.
-
-Planned next steps / TODOs (can be split to issues):
-- Integrate with NewPipe extractor API to handle YouTube pages/IDs -> actual video stream URLs (muxed/dash) (High priority)
-- Support background playback and notification controls (media session & notification)
-- Support playlists and queueing (play next/previous)
-- Add subtitle downloading and selection (TTML/SRT/WebVTT)
-- Add audio boost, hardware acceleration toggles, speed control, equalizer integration
-- Implement Chromecast / DLNA / Google Cast support
-- Improve UX: gestures (seek/surface brightness/volume), aspect-ratio toggles, resume playback
-- Add tests and instrumentation tests for intent handling and PiP flows
+Important integration notes:
+- YouTube: ExoPlayer cannot play raw youtube.com/watch?v= links. Use NewPipe's extractor module to transform a YouTube page/ID into direct stream URLs (muxed/DASH) before passing URIs to PlayerService.
+- Subtitles: This is currently a UI placeholder. To implement, supply VTT/SRT/TTML URLs from the extractor and attach the subtitle tracks to ExoPlayer in PlayerService.
+- Audio focus & interruptions: Basic playback is implemented; extend audio focus handling and proper interruption handling for production.
+- Casting, DRM, AD handling, advanced subtitle formats and timing are not in scope for this commit and should be added incrementally.
 
 How to test locally:
 1. Add `include ':external-player'` to your root settings.gradle
-2. Build and install the app variant or run as a standalone APK and send an ACTION_VIEW intent:
+2. Build and install.
+3. Start a direct HTTP(S) playable URL:
    adb shell am start -a android.intent.action.VIEW -d "https://www.example.com/video.mp4" org.newpipe.externalplayer/.ExternalPlayerActivity
-3. Share a YouTube URL via Android share sheet to the player to validate intent handling (extraction not implemented yet).
+4. Observe playback continues when you press Home (notification appears). Use notification controls to pause/play.
+5. Share a text containing a direct video URL via Android share sheet -> choose NewPipe External Player.
+6. Try the speed button to cycle speeds, and the SUB button to toggle the placeholder.
 
-Security & privacy notes:
-- Do not embed broken/unsafe YouTube extractors. Prefer reusing the app's extractor or server-assisted extraction. Respect Terms of Service where applicable.
-- If integrating with YouTube, prefer the app's existing extractor infrastructure to avoid duplicating logic and leaking credentials.
+Next steps:
+- Integrate with the app's extractor to resolve YouTube links into playable stream URLs.
+- Implement subtitles support in PlayerService and UI for subtitle selection.
+- Implement proper audio focus handling and media-button receiver plumbing.
+- Add instrumentation tests for service lifecycle and notification behavior.