SharedPreferences.edit applies changes automatically

Yevhen Babiichuk (DustDFG) · Yevhen Babiichuk (DustDFG) · commit 451409fc3bae · 2026-02-10T09:23:17.000+02:00
diff --git a/app/src/main/java/org/schabi/newpipe/local/feed/FeedViewModel.kt b/app/src/main/java/org/schabi/newpipe/local/feed/FeedViewModel.kt
@@ -129,8 +129,7 @@ class FeedViewModel(
     fun setSaveShowPlayedItems(showPlayedItems: Boolean) {
         this.showPlayedItems.onNext(showPlayedItems)
         PreferenceManager.getDefaultSharedPreferences(application).edit {
-            this.putBoolean(application.getString(R.string.feed_show_watched_items_key), showPlayedItems)
-            this.apply()
+            putBoolean(application.getString(R.string.feed_show_watched_items_key), showPlayedItems)
         }
     }
 
@@ -139,8 +138,7 @@ class FeedViewModel(
     fun setSaveShowPartiallyPlayedItems(showPartiallyPlayedItems: Boolean) {
         this.showPartiallyPlayedItems.onNext(showPartiallyPlayedItems)
         PreferenceManager.getDefaultSharedPreferences(application).edit {
-            this.putBoolean(application.getString(R.string.feed_show_partially_watched_items_key), showPartiallyPlayedItems)
-            this.apply()
+            putBoolean(application.getString(R.string.feed_show_partially_watched_items_key), showPartiallyPlayedItems)
         }
     }
 
@@ -149,8 +147,7 @@ class FeedViewModel(
     fun setSaveShowFutureItems(showFutureItems: Boolean) {
         this.showFutureItems.onNext(showFutureItems)
         PreferenceManager.getDefaultSharedPreferences(application).edit {
-            this.putBoolean(application.getString(R.string.feed_show_future_items_key), showFutureItems)
-            this.apply()
+            putBoolean(application.getString(R.string.feed_show_future_items_key), showFutureItems)
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,7 @@ class FeedViewModel(`
`129`	`129`	`fun setSaveShowPlayedItems(showPlayedItems: Boolean) {`
`130`	`130`	`this.showPlayedItems.onNext(showPlayedItems)`
`131`	`131`	`PreferenceManager.getDefaultSharedPreferences(application).edit {`
`132`		`- this.putBoolean(application.getString(R.string.feed_show_watched_items_key), showPlayedItems)`
`133`		`- this.apply()`
	`132`	`+ putBoolean(application.getString(R.string.feed_show_watched_items_key), showPlayedItems)`
`134`	`133`	`}`
`135`	`134`	`}`
`136`	`135`
`@@ -139,8 +138,7 @@ class FeedViewModel(`
`139`	`138`	`fun setSaveShowPartiallyPlayedItems(showPartiallyPlayedItems: Boolean) {`
`140`	`139`	`this.showPartiallyPlayedItems.onNext(showPartiallyPlayedItems)`
`141`	`140`	`PreferenceManager.getDefaultSharedPreferences(application).edit {`
`142`		`- this.putBoolean(application.getString(R.string.feed_show_partially_watched_items_key), showPartiallyPlayedItems)`
`143`		`- this.apply()`
	`141`	`+ putBoolean(application.getString(R.string.feed_show_partially_watched_items_key), showPartiallyPlayedItems)`
`144`	`142`	`}`
`145`	`143`	`}`
`146`	`144`
`@@ -149,8 +147,7 @@ class FeedViewModel(`
`149`	`147`	`fun setSaveShowFutureItems(showFutureItems: Boolean) {`
`150`	`148`	`this.showFutureItems.onNext(showFutureItems)`
`151`	`149`	`PreferenceManager.getDefaultSharedPreferences(application).edit {`
`152`		`- this.putBoolean(application.getString(R.string.feed_show_future_items_key), showFutureItems)`
`153`		`- this.apply()`
	`150`	`+ putBoolean(application.getString(R.string.feed_show_future_items_key), showFutureItems)`
`154`	`151`	`}`
`155`	`152`	`}`
`156`	`153`