feat: resolved review comments

Author: arjun1194

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -1280,10 +1280,6 @@ public void cycleNextRepeatMode() {
                     break;
             }
             simpleExoPlayer.setRepeatMode(repeatMode);
-            prefs
-                .edit()
-                .putInt(context.getString(R.string.repeat_mode_key), repeatMode)
-                .apply();
         }
     }
 
@@ -1295,6 +1291,10 @@ public void onRepeatModeChanged(@RepeatMode final int repeatMode) {
         }
         UIs.call(playerUi -> playerUi.onRepeatModeChanged(repeatMode));
         notifyPlaybackUpdateToListeners();
+        prefs
+            .edit()
+            .putInt(context.getString(R.string.repeat_mode_key), repeatMode)
+            .apply();
     }
 
     @Override

app/src/main/java/org/schabi/newpipe/player/ui/VideoPlayerUi.java

@@ -400,6 +400,8 @@ public void initPlayback() {
 
         // #6825 - Ensure that the shuffle-button is in the correct state on the UI
         setShuffleButton(player.getExoPlayer().getShuffleModeEnabled());
+        // Ensure that the repeat-button is in the correct state on the UI
+        setRepeatButton(player.getRepeatMode());
     }
 
     public abstract void removeViewFromParent();
@@ -951,16 +953,7 @@ public void onShuffleClicked() {
     public void onRepeatModeChanged(@RepeatMode final int repeatMode) {
         super.onRepeatModeChanged(repeatMode);
 
-        if (repeatMode == REPEAT_MODE_ALL) {
-            binding.repeatButton.setImageResource(
-                    com.google.android.exoplayer2.ui.R.drawable.exo_controls_repeat_all);
-        } else if (repeatMode == REPEAT_MODE_ONE) {
-            binding.repeatButton.setImageResource(
-                    com.google.android.exoplayer2.ui.R.drawable.exo_controls_repeat_one);
-        } else /* repeatMode == REPEAT_MODE_OFF */ {
-            binding.repeatButton.setImageResource(
-                    com.google.android.exoplayer2.ui.R.drawable.exo_controls_repeat_off);
-        }
+        setRepeatButton(repeatMode);
     }
 
     @Override
@@ -980,6 +973,19 @@ private void setMuteButton(final boolean isMuted) {
                 ? R.drawable.ic_volume_off : R.drawable.ic_volume_up));
     }
 
+    private void setRepeatButton(@RepeatMode final int repeatMode) {
+        if (repeatMode == REPEAT_MODE_ALL) {
+            binding.repeatButton.setImageResource(
+                    com.google.android.exoplayer2.ui.R.drawable.exo_controls_repeat_all);
+        } else if (repeatMode == REPEAT_MODE_ONE) {
+            binding.repeatButton.setImageResource(
+                    com.google.android.exoplayer2.ui.R.drawable.exo_controls_repeat_one);
+        } else /* repeatMode == REPEAT_MODE_OFF */ {
+            binding.repeatButton.setImageResource(
+                    com.google.android.exoplayer2.ui.R.drawable.exo_controls_repeat_off);
+        }
+    }
+
     private void setShuffleButton(final boolean shuffled) {
         binding.shuffleButton.setImageAlpha(shuffled ? 255 : 77);
     }