Display dialog informing the user about the removal of the Top 50 kiosk

Author: TobiGr

app/src/main/java/org/schabi/newpipe/MainActivity.java

@@ -80,6 +80,7 @@
 import org.schabi.newpipe.player.event.OnKeyDownListener;
 import org.schabi.newpipe.player.helper.PlayerHolder;
 import org.schabi.newpipe.player.playqueue.PlayQueue;
+import org.schabi.newpipe.settings.SettingMigrations;
 import org.schabi.newpipe.settings.UpdateSettingsFragment;
 import org.schabi.newpipe.util.Constants;
 import org.schabi.newpipe.util.DeviceUtils;
@@ -197,6 +198,7 @@ protected void onCreate(final Bundle savedInstanceState) {
         }
 
         Localization.migrateAppLanguageSettingIfNecessary(getApplicationContext());
+        SettingMigrations.showUserInfoIfPresent(this);
     }
 
     @Override

app/src/main/java/org/schabi/newpipe/settings/SettingMigrations.java

@@ -5,18 +5,20 @@
 import android.util.Log;
 
 import androidx.annotation.NonNull;
+import androidx.appcompat.app.AlertDialog;
+import androidx.core.util.Consumer;
 import androidx.preference.PreferenceManager;
 
 import org.schabi.newpipe.App;
 import org.schabi.newpipe.R;
 import org.schabi.newpipe.error.ErrorInfo;
 import org.schabi.newpipe.error.ErrorUtil;
 import org.schabi.newpipe.error.UserAction;
-import org.schabi.newpipe.extractor.ServiceList;
 import org.schabi.newpipe.settings.tabs.Tab;
 import org.schabi.newpipe.settings.tabs.TabsManager;
 import org.schabi.newpipe.util.DeviceUtils;
 
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
@@ -38,6 +40,12 @@ public final class SettingMigrations {
     private static final String TAG = SettingMigrations.class.toString();
     private static SharedPreferences sp;
 
+    /**
+     * List of UI actions that are be performed after the UI is initialized
+     * to inform the user about changes that were applied by migrations.
+     */
+    private static final List<Consumer<Context>> MIGRATION_INFO = new ArrayList<>();
+
     private static final Migration MIGRATION_0_1 = new Migration(0, 1) {
         @Override
         public void migrate(@NonNull final Context context) {
@@ -163,6 +171,15 @@ protected void migrate(@NonNull final Context context) {
                     .collect(Collectors.toUnmodifiableList());
             if (tabs.size() != cleanedTabs.size()) {
                 tabsManager.saveTabs(cleanedTabs);
+                // create an AlertDialog to inform the user about the change
+                // do not translate text, it is only shown once
+                MIGRATION_INFO.add((Context uiContext) -> new AlertDialog.Builder(uiContext)
+                            .setTitle("SoundCloud Top 50 page removed")
+                            .setMessage("SoundCloud has discontinued the original Top 50 charts. "
+                                    + "The corresponding tab has been removed from your main page.")
+                            .setPositiveButton(android.R.string.ok, null)
+                            .create()
+                            .show());
             }
         }
     };
@@ -233,6 +250,21 @@ public static void runMigrationsIfNeeded(@NonNull final Context context) {
         sp.edit().putInt(lastPrefVersionKey, currentVersion).apply();
     }
 
+    /**
+     * Perform UI actions informing about migrations that took place if they are present.
+     * @param context Context that can be used to show dialogs/snackbars/toasts
+     */
+    public static void showUserInfoIfPresent(@NonNull final Context context) {
+        for (final Consumer<Context> consumer : MIGRATION_INFO) {
+            try {
+                consumer.accept(context);
+            } catch (final Exception e) {
+                ErrorUtil.showUiErrorSnackbar(context, "Showing migration info to the user", e);
+            }
+        }
+        MIGRATION_INFO.clear();
+    }
+
     private SettingMigrations() { }
 
     abstract static class Migration {