Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment

TobiGr · TobiGr · commit 298e96b82195 · 2021-09-04T22:36:47.000+02:00
The comments tab was updated although the settings for the description tab were changed.
diff --git a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
@@ -423,7 +423,7 @@ public void onSharedPreferenceChanged(final SharedPreferences sharedPreferences,
             showRelatedItems = sharedPreferences.getBoolean(key, true);
             tabSettingsChanged = true;
         } else if (key.equals(getString(R.string.show_description_key))) {
-            showComments = sharedPreferences.getBoolean(key, true);
+            showDescription = sharedPreferences.getBoolean(key, true);
             tabSettingsChanged = true;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,7 @@ public void onSharedPreferenceChanged(final SharedPreferences sharedPreferences,`
`423`	`423`	`showRelatedItems = sharedPreferences.getBoolean(key, true);`
`424`	`424`	`tabSettingsChanged = true;`
`425`	`425`	`} else if (key.equals(getString(R.string.show_description_key))) {`
`426`		`- showComments = sharedPreferences.getBoolean(key, true);`
	`426`	`+ showDescription = sharedPreferences.getBoolean(key, true);`
`427`	`427`	`tabSettingsChanged = true;`
`428`	`428`	`}`
`429`	`429`	`}`