Skip to content

Commit 2277874

Browse files
committed
Player/handleIntent: a few comments
1 parent e1fda5c commit 2277874

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

app/src/main/java/org/schabi/newpipe/player/Player.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@ public void handleIntent(@NonNull final Intent intent) {
348348
final PlayerType oldPlayerType = playerType;
349349
playerType = PlayerType.retrieveFromIntent(intent);
350350
initUIsForCurrentPlayerType();
351+
// TODO: what does the following comment mean? Is that a relict?
351352
// We need to setup audioOnly before super(), see "sourceOf"
352353
isAudioOnly = audioPlayerSelected();
353354

@@ -360,24 +361,26 @@ public void handleIntent(@NonNull final Intent intent) {
360361
playQueue.append(newQueue.getStreams());
361362
return;
362363

363-
// Resolve enqueue next intents
364+
// Resolve enqueue next intents
364365
} else if (intent.getBooleanExtra(ENQUEUE_NEXT, false) && playQueue != null) {
365366
final int currentIndex = playQueue.getIndex();
366367
playQueue.append(newQueue.getStreams());
367368
playQueue.move(playQueue.size() - 1, currentIndex + 1);
368369
return;
369370
}
370371

372+
// initPlayback Parameters
371373
final PlaybackParameters savedParameters = retrievePlaybackParametersFromPrefs(this);
372374
final float playbackSpeed = savedParameters.speed;
373375
final float playbackPitch = savedParameters.pitch;
374376
final boolean playbackSkipSilence = getPrefs().getBoolean(getContext().getString(
375377
R.string.playback_skip_silence_key), getPlaybackSkipSilence());
376-
377-
final boolean samePlayQueue = playQueue != null && playQueue.equalStreamsAndIndex(newQueue);
378378
final int repeatMode = intent.getIntExtra(REPEAT_MODE, getRepeatMode());
379379
final boolean playWhenReady = intent.getBooleanExtra(PLAY_WHEN_READY, true);
380380

381+
// branching parameters for below
382+
final boolean samePlayQueue = playQueue != null && playQueue.equalStreamsAndIndex(newQueue);
383+
381384
/*
382385
* TODO As seen in #7427 this does not work:
383386
* There are 3 situations when playback shouldn't be started from scratch (zero timestamp):

0 commit comments

Comments
 (0)