Skip to content

Commit 1686060

Browse files
Yuuu2990opusforlife2Stypox
authored
Add Link to FAQ in the app (#9164)
* Link to FAQ in the app #4447 * remove redundant comments produced by me. * Update app/src/main/res/values/strings.xml Update FAQ description Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com> * Format the CodeStyle and readjust the layout. * Update app/src/main/res/layout/fragment_about.xml Remove redundant id. Co-authored-by: Stypox <stypox@pm.me> * Update app/src/main/res/layout/fragment_about.xml Remove redundant id. Co-authored-by: Stypox <stypox@pm.me> * Update app/src/main/res/values/strings.xml Keep the uppercase for consistency. Co-authored-by: Stypox <stypox@pm.me> * Update app/src/main/res/values/strings.xml Modify the description of FAQ. Co-authored-by: Stypox <stypox@pm.me> Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com> Co-authored-by: Stypox <stypox@pm.me>
1 parent 2a98cca commit 1686060

4 files changed

Lines changed: 26 additions & 1 deletion

File tree

app/src/main/java/org/schabi/newpipe/about/AboutActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ class AboutActivity : AppCompatActivity() {
7878
aboutDonationLink.openLink(R.string.donation_url)
7979
aboutWebsiteLink.openLink(R.string.website_url)
8080
aboutPrivacyPolicyLink.openLink(R.string.privacy_policy_url)
81+
faqLink.openLink(R.string.faq_url)
8182
return root
8283
}
8384
}

app/src/main/res/layout/fragment_about.xml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,26 @@
4444
android:paddingBottom="5dp"
4545
android:text="@string/app_description" />
4646

47+
<org.schabi.newpipe.views.NewPipeTextView
48+
android:layout_width="match_parent"
49+
android:layout_height="wrap_content"
50+
android:paddingTop="10dp"
51+
android:text="@string/faq_title"
52+
android:textAppearance="@android:style/TextAppearance.Medium" />
53+
54+
<TextView
55+
android:layout_width="match_parent"
56+
android:layout_height="wrap_content"
57+
android:text="@string/faq_description" />
58+
59+
<Button
60+
android:id="@+id/faq_link"
61+
style="@style/Base.Widget.AppCompat.Button.Borderless"
62+
android:layout_width="wrap_content"
63+
android:layout_height="wrap_content"
64+
android:layout_gravity="end"
65+
android:text="@string/faq" />
66+
4767
<org.schabi.newpipe.views.NewPipeTextView
4868
android:layout_width="match_parent"
4969
android:layout_height="wrap_content"

app/src/main/res/values/donottranslate.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<string name="donation_url">https://newpipe.net/donate/</string>
2222
<string name="website_url">https://newpipe.net/</string>
2323
<string name="privacy_policy_url">https://newpipe.net/legal/privacy/</string>
24+
<string name="faq_url">https://newpipe.net/FAQ/</string>
2425
<string name="service_kiosk_string">%1$s/%2$s</string>
2526
<string name="youtube">YouTube</string>
2627
<string name="soundcloud">SoundCloud</string>

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@
348348
<string name="title_activity_about">About NewPipe</string>
349349
<string name="title_licenses">Third-party Licenses</string>
350350
<string name="copyright">© %1$s by %2$s under %3$s</string>
351-
<string name="tab_about">About</string>
351+
<string name="tab_about">About \u0026 FAQ</string>
352352
<string name="tab_licenses">Licenses</string>
353353
<string name="app_description">Libre lightweight streaming on Android.</string>
354354
<string name="contribution_title">Contribute</string>
@@ -365,6 +365,9 @@
365365
<string name="app_license_title">NewPipe\'s License</string>
366366
<string name="app_license">NewPipe is copyleft libre software: You can use, study, share, and improve it at will. Specifically you can redistribute and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.</string>
367367
<string name="read_full_license">Read license</string>
368+
<string name="faq_title">Frequently asked questions</string>
369+
<string name="faq_description">If you are having trouble using the app, be sure to check out these answers to common questions!</string>
370+
<string name="faq">View on website</string>
368371
<!-- History -->
369372
<string name="title_activity_history">History</string>
370373
<string name="action_history">History</string>

0 commit comments

Comments
 (0)