Skip to content

Commit 161eb16

Browse files
committed
searchfilters: make dividerLabel inside ChipGroup use one row exclusivly
1 parent 6eef250 commit 161eb16

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

app/src/main/java/org/schabi/newpipe/fragments/list/search/filter/SearchFilterDialogGenerator.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,10 @@ protected void createUiChipElementsForFilterGroupItems(
188188
final InjectFilterItem.DividerItem dividerItem =
189189
(InjectFilterItem.DividerItem) item;
190190

191-
final GridLayout.LayoutParams layoutParams = getLayoutParamsViews();
191+
// For the width MATCH_PARENT is necessary as this allows the
192+
// dividerLabel to fill one row of ChipGroup exclusively
193+
final ChipGroup.LayoutParams layoutParams = new ChipGroup.LayoutParams(
194+
ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT);
192195
final TextView dividerLabel = createDividerLabel(dividerItem, layoutParams);
193196
chipGroup.addView(dividerLabel);
194197
} else {
@@ -221,17 +224,16 @@ private Chip createChipView(@NonNull final ChipGroup chipGroup,
221224
@NonNull
222225
private TextView createDividerLabel(
223226
@NonNull final InjectFilterItem.DividerItem dividerItem,
224-
@NonNull final GridLayout.LayoutParams layoutParams) {
227+
@NonNull final ViewGroup.MarginLayoutParams layoutParams) {
225228
final TextView dividerLabel;
226229
dividerLabel = new TextView(context);
227230
dividerLabel.setEnabled(true);
228231

229232
dividerLabel.setGravity(Gravity.CENTER_VERTICAL);
230233
setDefaultMargin(layoutParams);
231-
layoutParams.height = DeviceUtils.dpToPx(CHIP_MIN_TOUCH_TARGET_SIZE_DP, context);
232234
dividerLabel.setLayoutParams(layoutParams);
233235
final String menuDividerTitle =
234-
context.getString(dividerItem.getStringResId()) + ":";
236+
context.getString(dividerItem.getStringResId());
235237
dividerLabel.setText(menuDividerTitle);
236238
return dividerLabel;
237239
}

0 commit comments

Comments
 (0)