Skip to content

Commit 0b43dd2

Browse files
Bump minimum SDK version to API 23
- Updated the `minSdk` in `app/build.gradle.kts`. - Adjusted the api-level for the test-android min sdk CI workflow in `.github/workflows/ci.yml`. - Simplified the `getOsString()` method in `ErrorActivity.java` by removing the conditional check for `Build.VERSION_CODES.M`, as API 23 is now the minimum.
1 parent f5245ea commit 0b43dd2

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
strategy:
7070
matrix:
7171
include:
72-
- api-level: 21
72+
- api-level: 23
7373
target: default
7474
arch: x86
7575
- api-level: 35

app/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ android {
4444
defaultConfig {
4545
applicationId = "org.schabi.newpipe"
4646
resValue("string", "app_name", "NewPipe")
47-
minSdk = 21
47+
minSdk = 23
4848
targetSdk = 35
4949

5050
versionCode = System.getProperty("versionCodeOverride")?.toInt() ?: 1005

app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,7 @@ private String getAppLanguage() {
307307
}
308308

309309
private String getOsString() {
310-
final String osBase = Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
311-
? Build.VERSION.BASE_OS : "Android";
310+
final String osBase = Build.VERSION.BASE_OS;
312311
return System.getProperty("os.name")
313312
+ " " + (osBase.isEmpty() ? "Android" : osBase)
314313
+ " " + Build.VERSION.RELEASE

0 commit comments

Comments
 (0)