Skip to content

Commit 0536cb4

Browse files
Make play queue toolbar theme consistent with rest of app
1 parent ca944f4 commit 0536cb4

5 files changed

Lines changed: 6 additions & 22 deletions

File tree

app/src/main/java/org/schabi/newpipe/QueueItemMenuUtil.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import static org.schabi.newpipe.util.external_communication.ShareUtils.shareText;
55

66
import android.content.Context;
7-
import android.view.ContextThemeWrapper;
87
import android.view.View;
98
import android.widget.PopupMenu;
109

@@ -30,10 +29,7 @@ public static void openPopupMenu(final PlayQueue playQueue,
3029
final boolean hideDetails,
3130
final FragmentManager fragmentManager,
3231
final Context context) {
33-
final ContextThemeWrapper themeWrapper =
34-
new ContextThemeWrapper(context, R.style.DarkPopupMenu);
35-
36-
final PopupMenu popupMenu = new PopupMenu(themeWrapper, view);
32+
final PopupMenu popupMenu = new PopupMenu(context, view);
3733
popupMenu.inflate(R.menu.menu_play_queue_item);
3834

3935
if (hideDetails) {

app/src/main/java/org/schabi/newpipe/player/ui/VideoPlayerUi.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import androidx.annotation.NonNull;
4242
import androidx.annotation.Nullable;
4343
import androidx.appcompat.content.res.AppCompatResources;
44-
import androidx.appcompat.view.ContextThemeWrapper;
4544
import androidx.appcompat.widget.AppCompatImageButton;
4645
import androidx.appcompat.widget.PopupMenu;
4746
import androidx.core.graphics.BitmapCompat;
@@ -179,13 +178,10 @@ private void initViews() {
179178
binding.playbackSeekBar.getProgressDrawable()
180179
.setColorFilter(new PorterDuffColorFilter(Color.RED, PorterDuff.Mode.MULTIPLY));
181180

182-
final ContextThemeWrapper themeWrapper = new ContextThemeWrapper(context,
183-
R.style.DarkPopupMenu);
184-
185-
qualityPopupMenu = new PopupMenu(themeWrapper, binding.qualityTextView);
186-
audioTrackPopupMenu = new PopupMenu(themeWrapper, binding.audioTrackTextView);
181+
qualityPopupMenu = new PopupMenu(context, binding.qualityTextView);
182+
audioTrackPopupMenu = new PopupMenu(context, binding.audioTrackTextView);
187183
playbackSpeedPopupMenu = new PopupMenu(context, binding.playbackSpeed);
188-
captionPopupMenu = new PopupMenu(themeWrapper, binding.captionTextView);
184+
captionPopupMenu = new PopupMenu(context, binding.captionTextView);
189185

190186
binding.progressBarLoadingPanel.getIndeterminateDrawable()
191187
.setColorFilter(new PorterDuffColorFilter(Color.WHITE, PorterDuff.Mode.MULTIPLY));

app/src/main/res/layout-land/activity_player_queue_control.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,13 @@
1111
<com.google.android.material.appbar.AppBarLayout
1212
android:id="@+id/appbar"
1313
android:layout_width="match_parent"
14-
android:layout_height="wrap_content"
15-
android:theme="@style/ThemeOverlay.Material3.ActionBar"
16-
app:popupTheme="@style/ThemeOverlay.Material3.ActionBar">
14+
android:layout_height="wrap_content">
1715

1816
<androidx.appcompat.widget.Toolbar
1917
android:id="@+id/toolbar"
2018
android:layout_width="match_parent"
2119
android:layout_height="?attr/actionBarSize"
2220
android:layout_weight="1"
23-
android:background="?attr/colorPrimary"
2421
app:layout_scrollFlags="scroll|enterAlways"
2522
app:title="@string/app_name" />
2623

app/src/main/res/layout/activity_player_queue_control.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,13 @@
1111
<com.google.android.material.appbar.AppBarLayout
1212
android:id="@+id/appbar"
1313
android:layout_width="match_parent"
14-
android:layout_height="wrap_content"
15-
android:theme="@style/ThemeOverlay.Material3.ActionBar"
16-
app:popupTheme="@style/ThemeOverlay.Material3.ActionBar">
14+
android:layout_height="wrap_content">
1715

1816
<androidx.appcompat.widget.Toolbar
1917
android:id="@+id/toolbar"
2018
android:layout_width="match_parent"
2119
android:layout_height="?attr/actionBarSize"
2220
android:layout_weight="1"
23-
android:background="?attr/colorPrimary"
2421
app:layout_scrollFlags="scroll|enterAlways"
2522
app:title="@string/app_name" />
2623

app/src/main/res/values/styles_misc.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@
6666
<item name="tint">?attr/actionColor</item>
6767
</style>
6868

69-
<style name="DarkPopupMenu" parent="ThemeOverlay.Material3.Dark.ActionBar" />
70-
7169
<style name="ToolbarTheme" parent="ThemeOverlay.Material3.Dark.ActionBar">
7270
<item name="popupTheme">@style/ToolbarPopupTheme</item>
7371
<item name="android:textColorPrimary">?attr/actionColor</item>

0 commit comments

Comments
 (0)