Skip to content

Commit 0277b94

Browse files
committed
Fix error panel created in onViewCreated() but disposed in onDestroy()
1 parent c7efa8c commit 0277b94

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

app/src/main/java/org/schabi/newpipe/fragments/BaseStateFragment.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,6 @@ public void onResume() {
5656
}
5757
}
5858

59-
@Override
60-
public void onDestroy() {
61-
super.onDestroy();
62-
errorPanelHelper.dispose();
63-
}
64-
6559
/*//////////////////////////////////////////////////////////////////////////
6660
// Init
6761
//////////////////////////////////////////////////////////////////////////*/
@@ -74,6 +68,14 @@ protected void initViews(final View rootView, final Bundle savedInstanceState) {
7468
errorPanelHelper = new ErrorPanelHelper(this, rootView, this::onRetryButtonClicked);
7569
}
7670

71+
@Override
72+
public void onDestroyView() {
73+
super.onDestroyView();
74+
if (errorPanelHelper != null) {
75+
errorPanelHelper.dispose();
76+
}
77+
}
78+
7779
protected void onRetryButtonClicked() {
7880
reloadContent();
7981
}

0 commit comments

Comments
 (0)