Skip to content

Commit 34b8084

Browse files
committed
chore(angular): fix some of coderabbit nitpicks
1 parent 233fb61 commit 34b8084

File tree

8 files changed

+7
-11
lines changed

8 files changed

+7
-11
lines changed

packages/angular-virtual/e2e/app/src/app/app.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ApplicationConfig } from '@angular/core'
1+
import type { ApplicationConfig } from '@angular/core'
22
import { provideRouter } from '@angular/router'
33
import { routes } from './app.routes'
44

packages/angular-virtual/e2e/app/src/app/app.routes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Routes } from '@angular/router'
1+
import type { Routes } from '@angular/router'
22
import { MeasureElementComponent } from './measure-element.component'
33
import { SmoothScrollComponent } from './smooth-scroll.component'
44
import { ScrollComponent } from './scroll.component'

packages/angular-virtual/e2e/app/src/app/measure-element.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import {
22
ChangeDetectionStrategy,
33
Component,
4-
ElementRef,
54
afterRenderEffect,
65
signal,
76
viewChild,
87
viewChildren,
98
} from '@angular/core'
9+
import type { ElementRef } from '@angular/core'
1010
import { injectVirtualizer } from '@tanstack/angular-virtual'
1111

1212
interface Item {

packages/angular-virtual/e2e/app/src/app/scroll.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import {
22
ChangeDetectionStrategy,
33
Component,
4-
ElementRef,
54
afterRenderEffect,
65
viewChild,
76
viewChildren,
87
} from '@angular/core'
8+
import type { ElementRef } from '@angular/core'
99
import { injectVirtualizer } from '@tanstack/angular-virtual'
1010

1111
function getRandomInt(min: number, max: number) {

packages/angular-virtual/e2e/app/src/app/smooth-scroll.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import {
22
ChangeDetectionStrategy,
33
Component,
4-
ElementRef,
54
afterRenderEffect,
65
viewChild,
76
viewChildren,
87
} from '@angular/core'
8+
import type { ElementRef } from '@angular/core'
99
import { injectVirtualizer } from '@tanstack/angular-virtual'
1010

1111
function getRandomInt(min: number, max: number) {

packages/angular-virtual/e2e/app/src/app/stale-index.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import {
22
ChangeDetectionStrategy,
33
Component,
4-
ElementRef,
54
afterRenderEffect,
65
signal,
76
viewChild,
87
viewChildren,
98
} from '@angular/core'
9+
import type { ElementRef } from '@angular/core'
1010
import { injectVirtualizer } from '@tanstack/angular-virtual'
1111

1212
interface Item {

packages/angular-virtual/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@
3636
},
3737
"./package.json": "./package.json"
3838
},
39-
"engines": {
40-
"node": ">=12"
41-
},
4239
"files": [
4340
"dist",
4441
"src"

packages/angular-virtual/src/proxy.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export function signalProxy<
7676
// input or model signals from a component and this is accessed before initialization.
7777
return untracked(inputSignal)[property as keyof TInput]
7878
},
79-
has(_, property: string) {
79+
has(_, property: PropertyKey) {
8080
return property in untracked(inputSignal)
8181
},
8282
ownKeys() {
@@ -86,7 +86,6 @@ export function signalProxy<
8686
return {
8787
enumerable: true,
8888
configurable: true,
89-
writable: true,
9089
}
9190
},
9291
}) as SignalProxy<

0 commit comments

Comments
 (0)