chore: enable tsdown devExports, move eslint to tsdown (#325)

lachlancollins · web-flow · commit cd8cd02ae164 · 2025-12-06T08:51:13.000+11:00
* chore: enable tsdown devExports

* Move eslint to tsdown

* Add changeset
diff --git a/.changeset/cute-pandas-ask.md b/.changeset/cute-pandas-ask.md
@@ -0,0 +1,5 @@
+---
+'@tanstack/vite-config': patch
+---
+
+chore: use publishConfig exports
diff --git a/.changeset/quick-hounds-train.md b/.changeset/quick-hounds-train.md
@@ -0,0 +1,5 @@
+---
+'@tanstack/eslint-config': patch
+---
+
+chore(eslint): move to tsdown
diff --git a/nx.json b/nx.json
@@ -4,6 +4,9 @@
   "nxCloudId": "65cc80a2ddc7c22ebb07831c",
   "useInferencePlugins": false,
   "parallel": 5,
+  "tui": {
+    "enabled": false
+  },
   "targetDefaults": {
     "test:docs": {
       "cache": true,
@@ -14,20 +17,16 @@
       "inputs": ["{workspaceRoot}/**/package.json"]
     },
     "test:eslint": {
-      "cache": true,
-      "dependsOn": ["^build"]
+      "cache": true
     },
     "test:types": {
-      "cache": true,
-      "dependsOn": ["^build"]
+      "cache": true
     },
     "build": {
-      "cache": true,
-      "dependsOn": ["^build"]
+      "cache": true
     },
     "test:build": {
-      "cache": true,
-      "dependsOn": ["build"]
+      "cache": true
     }
   }
 }
diff --git a/package.json b/package.json
@@ -40,6 +40,7 @@
     "@svitejs/changesets-changelog-github-compact": "catalog:",
     "@types/node": "catalog:",
     "eslint": "catalog:",
+    "jiti": "catalog:",
     "jsdom": "catalog:",
     "markdown-link-extractor": "catalog:",
     "nx": "catalog:",
diff --git a/packages/eslint-config/eslint.config.js b/packages/eslint-config/eslint.config.js
diff --git a/packages/eslint-config/eslint.config.ts b/packages/eslint-config/eslint.config.ts
@@ -0,0 +1,5 @@
+// @ts-check
+
+import { tanstackConfig } from '@tanstack/eslint-config'
+
+export default [...tanstackConfig]
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -17,21 +17,26 @@
   "scripts": {
     "test:types": "tsc",
     "test:eslint": "eslint --concurrency=auto ./src",
-    "test:build": "publint --strict"
+    "build": "tsdown"
   },
   "type": "module",
+  "main": "./dist/index.js",
+  "module": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "exports": {
-    ".": {
-      "import": {
-        "types": "./src/index.d.ts",
-        "default": "./src/index.js"
-      }
-    },
+    ".": "./src/index.ts",
     "./package.json": "./package.json"
   },
+  "publishConfig": {
+    "exports": {
+      ".": "./dist/index.js",
+      "./package.json": "./package.json"
+    }
+  },
   "preferGlobal": false,
   "sideEffects": false,
   "files": [
+    "dist",
     "src"
   ],
   "engines": {
@@ -48,6 +53,10 @@
   },
   "devDependencies": {
     "@types/eslint": "catalog:",
-    "eslint": "catalog:"
+    "eslint": "catalog:",
+    "tsdown": "catalog:"
+  },
+  "peerDependencies": {
+    "eslint": "^8.0.0 || ^9.0.0"
   }
 }
diff --git a/packages/eslint-config/src/import.ts b/packages/eslint-config/src/import.ts
@@ -1,7 +1,9 @@
-// https://github.com/un-ts/eslint-plugin-import-x
+import type { Linter } from 'eslint'
 
-/** @type {import('eslint').Linter.RulesRecord} */
-export const importRules = {
+/**
+ * @see https://github.com/un-ts/eslint-plugin-import-x
+ */
+export const importRules: Linter.RulesRecord = {
   /** Bans the use of inline type-only markers for named imports */
   'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
   /** Reports any imports that come after non-import statements */
diff --git a/packages/eslint-config/src/index.d.ts b/packages/eslint-config/src/index.d.ts
diff --git a/packages/eslint-config/src/index.ts b/packages/eslint-config/src/index.ts
@@ -9,6 +9,7 @@ import { importRules } from './import.js'
 import { typescriptRules } from './typescript.js'
 import { nodeRules } from './node.js'
 import { stylisticRules } from './stylistic.js'
+import type { Linter } from 'eslint'
 
 const GLOB_EXCLUDE = [
   '**/.nx/**',
@@ -35,8 +36,7 @@ const jsPlugins = {
   node: nodePlugin,
 }
 
-/** @type {Array<import('eslint').Linter.Config>} */
-export const tanstackConfig = [
+export const tanstackConfig: Array<Linter.Config> = [
   {
     name: 'tanstack/ignores',
     ignores: GLOB_EXCLUDE,
diff --git a/packages/eslint-config/src/javascript.ts b/packages/eslint-config/src/javascript.ts
@@ -1,7 +1,9 @@
-// https://eslint.org/docs/latest/rules/
+import type { Linter } from 'eslint'
 
-/** @type {import('eslint').Linter.RulesRecord} */
-export const javascriptRules = {
+/**
+ * @see https://eslint.org/docs/latest/rules/
+ */
+export const javascriptRules: Linter.RulesRecord = {
   /** TODO */
   'for-direction': 'error',
   'no-async-promise-executor': 'error',
diff --git a/packages/eslint-config/src/node.js b/packages/eslint-config/src/node.js
diff --git a/packages/eslint-config/src/node.ts b/packages/eslint-config/src/node.ts
@@ -0,0 +1,9 @@
+import type { Linter } from 'eslint'
+
+/**
+ * @see https://github.com/eslint-community/eslint-plugin-n
+ */
+export const nodeRules: Linter.RulesRecord = {
+  /** Enforce usage of the `node:` prefix for builtin imports */
+  'node/prefer-node-protocol': 'error',
+}
diff --git a/packages/eslint-config/src/stylistic.js b/packages/eslint-config/src/stylistic.js
diff --git a/packages/eslint-config/src/stylistic.ts b/packages/eslint-config/src/stylistic.ts
@@ -0,0 +1,9 @@
+import type { Linter } from 'eslint'
+
+/**
+ * @see https://eslint.style/packages/js
+ */
+export const stylisticRules: Linter.RulesRecord = {
+  /** Enforce consistency of spacing after the start of a comment */
+  '@stylistic/spaced-comment': 'error',
+}
diff --git a/packages/eslint-config/src/typescript.ts b/packages/eslint-config/src/typescript.ts
@@ -1,7 +1,9 @@
-// https://typescript-eslint.io/rules/
+import type { Linter } from 'eslint'
 
-/** @type {import('eslint').Linter.RulesRecord} */
-export const typescriptRules = {
+/**
+ * @see https://typescript-eslint.io/rules/
+ */
+export const typescriptRules: Linter.RulesRecord = {
   /** Prefer Array<T> format */
   '@typescript-eslint/array-type': [
     'error',
diff --git a/packages/eslint-config/tsconfig.json b/packages/eslint-config/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "checkJs": true
+    "isolatedDeclarations": true
   },
-  "include": ["src", "*.config.*"]
+  "include": ["src"]
 }
diff --git a/packages/eslint-config/tsdown.config.ts b/packages/eslint-config/tsdown.config.ts
@@ -0,0 +1,22 @@
+import { defineConfig } from 'tsdown'
+
+export default defineConfig({
+  entry: ['./src/index.ts'],
+  format: ['esm'],
+  unbundle: true,
+  dts: true,
+  sourcemap: true,
+  clean: true,
+  minify: false,
+  fixedExtension: false,
+  exports: {
+    devExports: true,
+  },
+  publint: {
+    strict: true,
+  },
+  attw: {
+    profile: 'esm-only',
+    level: 'error',
+  },
+})
diff --git a/packages/publish-config/eslint.config.js b/packages/publish-config/eslint.config.js
diff --git a/packages/publish-config/eslint.config.ts b/packages/publish-config/eslint.config.ts
@@ -0,0 +1,5 @@
+// @ts-check
+
+import { tanstackConfig } from '@tanstack/eslint-config'
+
+export default [...tanstackConfig]
diff --git a/packages/publish-config/package.json b/packages/publish-config/package.json
@@ -44,6 +44,7 @@
     "simple-git": "catalog:"
   },
   "devDependencies": {
+    "@tanstack/eslint-config": "workspace:*",
     "@types/jsonfile": "catalog:",
     "@types/semver": "catalog:",
     "type-fest": "catalog:"
diff --git a/packages/typedoc-config/eslint.config.js b/packages/typedoc-config/eslint.config.js
diff --git a/packages/typedoc-config/eslint.config.ts b/packages/typedoc-config/eslint.config.ts
@@ -0,0 +1,5 @@
+// @ts-check
+
+import { tanstackConfig } from '@tanstack/eslint-config'
+
+export default [...tanstackConfig]
diff --git a/packages/typedoc-config/package.json b/packages/typedoc-config/package.json
@@ -41,5 +41,8 @@
     "typedoc": "catalog:",
     "typedoc-plugin-frontmatter": "catalog:",
     "typedoc-plugin-markdown": "catalog:"
+  },
+  "devDependencies": {
+    "@tanstack/eslint-config": "workspace:*"
   }
 }
diff --git a/packages/vite-config/eslint.config.js b/packages/vite-config/eslint.config.js
diff --git a/packages/vite-config/eslint.config.ts b/packages/vite-config/eslint.config.ts
@@ -0,0 +1,5 @@
+// @ts-check
+
+import { tanstackConfig } from '@tanstack/eslint-config'
+
+export default [...tanstackConfig]
diff --git a/packages/vite-config/package.json b/packages/vite-config/package.json
@@ -20,15 +20,19 @@
     "build": "tsdown"
   },
   "type": "module",
+  "main": "./dist/index.js",
+  "module": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "exports": {
-    ".": {
-      "import": {
-        "types": "./dist/index.d.ts",
-        "default": "./dist/index.js"
-      }
-    },
+    ".": "./src/index.ts",
     "./package.json": "./package.json"
   },
+  "publishConfig": {
+    "exports": {
+      ".": "./dist/index.js",
+      "./package.json": "./package.json"
+    }
+  },
   "preferGlobal": false,
   "sideEffects": false,
   "files": [
@@ -45,6 +49,7 @@
     "vite-tsconfig-paths": "catalog:"
   },
   "devDependencies": {
+    "@tanstack/eslint-config": "workspace:*",
     "tsdown": "catalog:",
     "vite": "catalog:"
   },
diff --git a/packages/vite-config/tsconfig.json b/packages/vite-config/tsconfig.json
@@ -3,5 +3,5 @@
   "compilerOptions": {
     "isolatedDeclarations": true
   },
-  "include": ["src", "*.config.*"]
+  "include": ["src"]
 }
diff --git a/packages/vite-config/tsdown.config.ts b/packages/vite-config/tsdown.config.ts
@@ -1,15 +1,17 @@
 import { defineConfig } from 'tsdown'
-import type { UserConfig } from 'tsdown'
 
-const config: UserConfig = defineConfig({
-  entry: ['./src/*.ts'],
+export default defineConfig({
+  entry: ['./src/index.ts'],
   format: ['esm'],
   unbundle: true,
   dts: true,
   sourcemap: true,
   clean: true,
   minify: false,
   fixedExtension: false,
+  exports: {
+    devExports: true,
+  },
   publint: {
     strict: true,
   },
@@ -18,5 +20,3 @@ const config: UserConfig = defineConfig({
     level: 'error',
   },
 })
-
-export default config
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
diff --git a/tsconfig.json b/tsconfig.json

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@tanstack/vite-config': patch
 +---
++
 +chore: use publishConfig exports