Fix empty project name prompt crash#471
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughFixes a crash when interactive project name prompts return undefined by adding null-safety to ChangesHandle Empty Project Name Input
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/cli/tests/ui-prompts.test.tsParsing error: "parserOptions.project" has been provided for Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
cc @tannerlinsley fyi, I notice an issue while starting a new project. Maybe the fix is helpful. thanks |
|
thanks, i see you already merged! |
Summary
Test plan
pnpm buildandpnpm test; visible output showed build, unit tests, and all 3 blocking e2e specs passed, but the Playwright runner hung after reporting the passing specs.Summary by CodeRabbit
Bug Fixes
Tests