From 90a6a06b74274ef345bbbbf46a191aa1809ad3f6 Mon Sep 17 00:00:00 2001 From: T-Crypt Date: Tue, 13 Oct 2026 11:18:28 -0600 Subject: [PATCH] ci: the workflow's comment counts what the run prints The self-review found two claims that do not match the logs: the skip is 139 tests with 501 left, not 137 and 503, and one of the two cited runs was a layout assertion that failed in 8 s under the ten second budget, not a thirty second expiry. --- .github/workflows/ci.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 842dee4e..e7d21dee 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,11 +18,12 @@ jobs: matrix: node: ["22.19", "24"] env: - # A path that is not a file makes findBrowser() return undefined, so the 137 tests that need a browser - # skip themselves and say why; the other 503 tests, and the checks above, still fail the job. The - # reason is the runner's browser, not the suite: the deb's Chrome 154 starts and passes most of the - # suite, then a wait this suite makes never resolves, a different one each run, with a thirty second - # budget expired and 638 of 640 tests green (runs 38431886203 and 38433132571, the 22.19 leg). + # A path that is not a file makes findBrowser() return undefined, so the 139 tests that need a browser + # skip themselves and say why; the other 501 tests, and the checks above, still fail the job. The + # reason is the runner's browser, not the suite: the tests that need one fail there on waits that + # never resolve, a different one each run, with the budget expired and most of the suite green (run + # 38433132571: 638 of 640 passed, the 22.19 leg; 38429902721 and 38429841208 the same, on the ten + # second budget the waits had then). Ticket 7K0XBQD is where the runner's browser gets worked out. PI_POCKET_BROWSER: /nonexistent-browser-on-ci steps: - uses: actions/checkout@v7