Use "done" button to close license dialogs.

Rename string res "recaptcha_done_button" to "done".

Author: TobiGr

app/src/main/java/org/schabi/newpipe/about/LicenseFragment.kt

@@ -106,15 +106,12 @@ class LicenseFragment : Fragment() {
                         .setView(webView)
                         .setOnCancelListener { activeSoftwareComponent = null }
                         .setOnDismissListener { activeSoftwareComponent = null }
-                    if (softwareComponent == NEWPIPE_SOFTWARE_COMPONENT) {
-                        builder.setPositiveButton(R.string.ok) { dialog, _ -> dialog.dismiss() }
-                    } else {
-                        builder.setPositiveButton(R.string.dismiss) { dialog, _ ->
-                            dialog.dismiss()
+                        .setPositiveButton(R.string.done) { dialog, _ -> dialog.dismiss() }
+
+                    if (softwareComponent != NEWPIPE_SOFTWARE_COMPONENT) {
+                        builder.setNeutralButton(R.string.open_website_license) { _, _ ->
+                            ShareUtils.openUrlInApp(requireContext(), softwareComponent.link)
                         }
-                            .setNeutralButton(R.string.open_website_license) { _, _ ->
-                                ShareUtils.openUrlInApp(requireContext(), softwareComponent.link)
-                            }
                     }
 
                     builder.show()

app/src/main/res/menu/menu_recaptcha.xml

@@ -5,6 +5,6 @@
     <item
         android:id="@+id/menu_item_done"
         android:icon="@drawable/ic_done"
-        android:title="@string/recaptcha_done_button"
+        android:title="@string/done"
         app:showAsAction="always" />
 </menu>

app/src/main/res/values-ar/strings.xml

@@ -466,7 +466,7 @@
     <string name="app_language_title">لغة التطبيق</string>
     <string name="systems_language">النظام الافتراضي</string>
     <string name="subtitle_activity_recaptcha">اضغط على \"تم\" عند حلها</string>
-    <string name="recaptcha_done_button">منجز</string>
+    <string name="done">منجز</string>
     <string name="videos_string">الفيديوهات</string>
     <plurals name="seconds">
         <item quantity="zero">%d ثانية</item>

app/src/main/res/values-az/strings.xml

@@ -327,7 +327,7 @@
     <string name="no_dir_yet">Hələ endirmə qovluğu təyin edilməyib, indi standart endirmə qovluğu seç</string>
     <string name="title_activity_recaptcha">reCAPTCHA çağırışı</string>
     <string name="recaptcha_request_toast">reCAPTCHA sorğusu göndərildi</string>
-    <string name="recaptcha_done_button">Bitdi</string>
+    <string name="done">Bitdi</string>
     <string name="settings_file_replacement_character_summary">Etibarsız simvollar bu dəyərlə əvəz olunur</string>
     <string name="settings_file_replacement_character_title">Əvəzedici xarakter</string>
     <string name="charset_most_special_characters">Ən xüsusi simvollar</string>

app/src/main/res/values-b+ast/strings.xml

@@ -420,7 +420,7 @@
     <string name="app_description">Un aplicación llibre pa ver/sentir plataformes de tresmisión n\'Android.</string>
     <string name="settings_file_replacement_character_title">Caráuteres de troquéu</string>
     <string name="settings_file_replacement_character_summary">Los caráuteres que nun son válidos van trocase por esti valor</string>
-    <string name="recaptcha_done_button">Fecho</string>
+    <string name="done">Fecho</string>
     <string name="subtitle_activity_recaptcha">Primi «Fecho» al resolvelu</string>
     <string name="one_item_deleted">Desanicióse 1 elementu.</string>
     <string name="no_available_dir">Defini una capeta de descargues dempués, nos axustes de l\'aplicación</string>

app/src/main/res/values-b+uz+Latn/strings.xml

@@ -214,7 +214,7 @@
     <string name="settings_file_replacement_character_summary">Noto\'g\'ri belgilar ushbu qiymat bilan almashtiriladi</string>
     <string name="settings_file_charset_title">Fayl nomidagi ruxsat berilgan belgilar</string>
     <string name="settings_category_downloads_title">Yuklab olish</string>
-    <string name="recaptcha_done_button">Bajarildi</string>
+    <string name="done">Bajarildi</string>
     <string name="recaptcha_request_toast">reCAPTCHA muammosi so\'raldi</string>
     <string name="subtitle_activity_recaptcha">Hal etilganda \"Bajarildi\" tugmasini bosing</string>
     <string name="title_activity_recaptcha">reCAPTCHA muammosi</string>

app/src/main/res/values-be/strings.xml

@@ -453,7 +453,7 @@
     <string name="no_playlist_bookmarked_yet">Няма закладак у плейлісце</string>
     <string name="select_a_playlist">Выберыце плэйліст</string>
     <string name="default_kiosk_page_summary">Кіёск па змаўчанні</string>
-    <string name="recaptcha_done_button">Так</string>
+    <string name="done">Так</string>
     <string name="subtitle_activity_recaptcha">Націсніце \"Так\" калі вырашана</string>
     <string name="infinite_videos">∞ відэа</string>
     <string name="more_than_100_videos">100+ відэа</string>

app/src/main/res/values-bg/strings.xml

@@ -445,7 +445,7 @@
     <string name="detail_heart_img_view_description">Отбелязан със сърце от автора</string>
     <string name="conferences">Конференции</string>
     <string name="most_liked">Най-харесвани</string>
-    <string name="recaptcha_done_button">Готово</string>
+    <string name="done">Готово</string>
     <string name="comments_tab_description">Коментари</string>
     <string name="localization_changes_requires_app_restart">Езикът ще се смени след рестартиране на приложението</string>
     <string name="metadata_privacy_unlisted">Скрит</string>

app/src/main/res/values-bn-rBD/strings.xml

@@ -257,7 +257,7 @@
     <string name="peertube_instance_url_title">পিয়ার টিউব এর ইন্সটান্স সমূহ</string>
     <string name="grid">ছক</string>
     <string name="local">স্থানীয়</string>
-    <string name="recaptcha_done_button">হয়েছে</string>
+    <string name="done">হয়েছে</string>
     <string name="events">ইভেন্টগুলো</string>
     <string name="settings_category_updates_title">আপডেট</string>
     <string name="minimize_on_exit_none_description">কোনোটি না</string>

app/src/main/res/values-bn-rIN/strings.xml

@@ -239,7 +239,7 @@
     <string name="contribution_title">যোগদান</string>
     <string name="title_activity_about">নিউ পাইপ এর সম্বন্ধে</string>
     <string name="charset_letters_and_digits">শব্দ ও নম্বর</string>
-    <string name="recaptcha_done_button">হয়েছে</string>
+    <string name="done">হয়েছে</string>
     <string name="no_comments">কোন মন্তব্য নেই</string>
     <string name="no_subscribers">কোন সাবস্ক্রাইবার নেই</string>
     <string name="no_streams_available_download">ডাউন লোড এর জন্য কোন স্ট্রিম নেই</string>