fix: Ignore @media queries

Ref: #7

Author: Stranger6667

CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+
+## [Unreleased]
+
+### Fixed
+
+- Ignore `@media` queries, since they can not be inlined. [#7](https://github.com/Stranger6667/css-inline/issues/7)
+
+## 0.1.0 - 2020-06-22
+
+- Initial public release
+
+[Unreleased]: https://github.com/Stranger6667/jsonschema-rs/compare/v0.1.0...HEAD

src/lib.rs

@@ -135,25 +135,28 @@ pub fn inline(html: &str) -> Result<String, InlineError> {
                 let mut parse_input = cssparser::ParserInput::new(css.as_str());
                 let mut parser = parse::CSSParser::new(&mut parse_input);
                 for parsed in parser.parse() {
-                    let (selector, declarations) = parsed?;
-                    let rule = Rule::new(&selector, declarations)
-                        .map_err(|_| error::InlineError::ParseError)?;
-                    let matching_elements = document
-                        .inclusive_descendants()
-                        .filter_map(|node| node.into_element_ref())
-                        .filter(|element| rule.selectors.matches(element));
-                    for matching_element in matching_elements {
-                        let mut attributes = matching_element.attributes.borrow_mut();
-                        let style = if let Some(existing_style) = attributes.get("style") {
-                            merge_styles(existing_style, &rule.declarations)?
-                        } else {
-                            rule.declarations
-                                .iter()
-                                .map(|&(ref key, ref value)| format!("{}:{};", key, value))
-                                .collect()
-                        };
-                        attributes.insert("style", style);
+                    if let Ok((selector, declarations)) = parsed {
+                        let rule = Rule::new(&selector, declarations)
+                            .map_err(|_| error::InlineError::ParseError)?;
+                        let matching_elements = document
+                            .inclusive_descendants()
+                            .filter_map(|node| node.into_element_ref())
+                            .filter(|element| rule.selectors.matches(element));
+                        for matching_element in matching_elements {
+                            let mut attributes = matching_element.attributes.borrow_mut();
+                            let style = if let Some(existing_style) = attributes.get("style") {
+                                merge_styles(existing_style, &rule.declarations)?
+                            } else {
+                                rule.declarations
+                                    .iter()
+                                    .map(|&(ref key, ref value)| format!("{}:{};", key, value))
+                                    .collect()
+                            };
+                            attributes.insert("style", style);
+                        }
                     }
+                    // Ignore not parsable entries. E.g. there is no parser for @media queries
+                    // Which means that they will fall into this category and will be ignored
                 }
             }
         }

tests/test_inlining.rs

@@ -75,3 +75,17 @@ fn empty_style() {
         expected = r#"<h1>Hello world!</h1>"#
     )
 }
+
+#[test]
+fn media_query_ignore() {
+    // When the style value includes @media query
+    assert_inlined!(
+        style = r#"@media screen and (max-width: 992px) {
+  body {
+    background-color: blue;
+  }
+}"#,
+        body = "<h1>Hello world!</h1>",
+        expected = "<h1>Hello world!</h1>"
+    )
+}