feat: Option to remove "style" tags

Stranger6667 · Stranger6667 · commit 3f8830d2c9a3 · 2020-06-23T23:01:32.000+02:00
Ref: #11
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Added
 
 - `CSSInliner` and customization options. [#9](https://github.com/Stranger6667/css-inline/issues/9)
+- Option to remove "style" tags. [#11](https://github.com/Stranger6667/css-inline/issues/11)
 
 ### Changed
 
diff --git a/src/lib.rs b/src/lib.rs
@@ -95,7 +95,7 @@
 //! </html>"#;
 //!
 //!fn main() -> Result<(), css_inline::InlineError> {
-//!    let options = css_inline::InlineOptions {};
+//!    let options = css_inline::InlineOptions { remove_style_tags: true };
 //!    let inliner = css_inline::CSSInliner::new(options);
 //!    let inlined = inliner.inline(HTML)?;
 //!    // Do something with inlined HTML, e.g. send an email
@@ -154,12 +154,17 @@ impl Rule {
 
 /// Configuration options for CSS inlining process.
 #[derive(Debug)]
-pub struct InlineOptions {}
+pub struct InlineOptions {
+    /// Remove "style" tags after inlining
+    pub remove_style_tags: bool,
+}
 
 impl Default for InlineOptions {
     #[inline]
     fn default() -> Self {
-        InlineOptions {}
+        InlineOptions {
+            remove_style_tags: false,
+        }
     }
 }
 
@@ -216,6 +221,9 @@ impl CSSInliner {
                     }
                 }
             }
+            if self.options.remove_style_tags {
+                style_tag.as_node().detach()
+            }
         }
         let mut out = vec![];
         document.serialize(&mut out)?;
diff --git a/tests/test_inlining.rs b/tests/test_inlining.rs
@@ -1,4 +1,4 @@
-use css_inline::inline;
+use css_inline::{inline, CSSInliner, InlineOptions};
 
 macro_rules! html {
     ($style: expr, $body: expr) => {
@@ -100,3 +100,14 @@ fn invalid_rule() {
     assert!(result.is_err());
     assert_eq!(result.unwrap_err().to_string(), "Invalid @ rule: wrong")
 }
+
+#[test]
+fn remove_style_tag() {
+    let html = html!("h1 {background-color: blue;}", "<h1>Hello world!</h1>");
+    let options = InlineOptions {
+        remove_style_tags: true,
+    };
+    let inliner = CSSInliner::new(options);
+    let result = inliner.inline(&html).unwrap();
+    assert_eq!(result, "<html><head><title>Test</title></head><body><h1 style=\"background-color: blue;\">Hello world!</h1></body></html>")
+}

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@`
`95`	`95`	`//! </html>"#;`
`96`	`96`	`//!`
`97`	`97`	`//!fn main() -> Result<(), css_inline::InlineError> {`
`98`		`-//! let options = css_inline::InlineOptions {};`
	`98`	`+//! let options = css_inline::InlineOptions { remove_style_tags: true };`
`99`	`99`	`//! let inliner = css_inline::CSSInliner::new(options);`
`100`	`100`	`//! let inlined = inliner.inline(HTML)?;`
`101`	`101`	`//! // Do something with inlined HTML, e.g. send an email`
`@@ -154,12 +154,17 @@ impl Rule {`
`154`	`154`
`155`	`155`	`/// Configuration options for CSS inlining process.`
`156`	`156`	`#[derive(Debug)]`
`157`		`-pub struct InlineOptions {}`
	`157`	`+pub struct InlineOptions {`
	`158`	`+ /// Remove "style" tags after inlining`
	`159`	`+ pub remove_style_tags: bool,`
	`160`	`+}`
`158`	`161`
`159`	`162`	`impl Default for InlineOptions {`
`160`	`163`	`#[inline]`
`161`	`164`	`fn default() -> Self {`
`162`		`- InlineOptions {}`
	`165`	`+ InlineOptions {`
	`166`	`+ remove_style_tags: false,`
	`167`	`+ }`
`163`	`168`	`}`
`164`	`169`	`}`
`165`	`170`
`@@ -216,6 +221,9 @@ impl CSSInliner {`
`216`	`221`	`}`
`217`	`222`	`}`
`218`	`223`	`}`
	`224`	`+ if self.options.remove_style_tags {`
	`225`	`+ style_tag.as_node().detach()`
	`226`	`+ }`
`219`	`227`	`}`
`220`	`228`	`let mut out = vec![];`
`221`	`229`	`document.serialize(&mut out)?;`