chore: Improve filesystem error messages on WASM

Stranger6667 · Stranger6667 · commit 2471324cd6d4 · 2023-12-28T03:35:08.000+01:00
diff --git a/bindings/javascript/__test__/wasm.spec.ts b/bindings/javascript/__test__/wasm.spec.ts
@@ -89,3 +89,18 @@ test("unsupported network operation", (t) => {
     "Loading remote stylesheets is not supported on WASM: http://127.0.0.1:5000/external.css",
   );
 });
+
+test("unsupported filesystem operation", (t) => {
+  const error = t.throws(
+    () => {
+      inline(
+        "<html><head><link href='tests/external.css' rel='stylesheet' type='text/css'></head><body></body></html>",
+      );
+    },
+    { any: true },
+  );
+  t.is(
+    error,
+    "Loading local files is not supported on WASM: tests/external.css",
+  );
+});
diff --git a/bindings/javascript/src/errors.rs b/bindings/javascript/src/errors.rs
@@ -37,11 +37,13 @@ impl From<InlineError> for napi::Error {
 #[cfg(target_arch = "wasm32")]
 impl From<InlineError> for JsValue {
     fn from(error: InlineError) -> Self {
-        if let css_inline::InlineError::IO(error) = &error.0 {
-            panic!("{}", error);
-        }
         match &error.0 {
             css_inline::InlineError::ParseError(e) => JsValue::from_str(e),
+            css_inline::InlineError::IO(io_error)
+                if io_error.kind() == std::io::ErrorKind::Unsupported =>
+            {
+                JsValue::from_str(io_error.to_string().as_str())
+            }
             css_inline::InlineError::Network {
                 error: network_error,
                 location,
diff --git a/bindings/javascript/wasm/index.js b/bindings/javascript/wasm/index.js
@@ -274,15 +274,15 @@ function __wbg_get_imports() {
     const ret = typeof v === "boolean" ? v ? 1 : 0 : 2;
     return ret;
   };
+  imports.wbg.__wbindgen_string_new = function(arg0, arg1) {
+    const ret = getStringFromWasm0(arg0, arg1);
+    return addHeapObject(ret);
+  };
   imports.wbg.__wbindgen_is_object = function(arg0) {
     const val = getObject(arg0);
     const ret = typeof val === "object" && val !== null;
     return ret;
   };
-  imports.wbg.__wbindgen_string_new = function(arg0, arg1) {
-    const ret = getStringFromWasm0(arg0, arg1);
-    return addHeapObject(ret);
-  };
   imports.wbg.__wbindgen_object_clone_ref = function(arg0) {
     const ret = getObject(arg0);
     return addHeapObject(ret);
diff --git a/bindings/javascript/wasm/index.min.js b/bindings/javascript/wasm/index.min.js
diff --git a/bindings/javascript/wasm/index.mjs b/bindings/javascript/wasm/index.mjs
@@ -246,15 +246,15 @@ function __wbg_get_imports() {
     const ret = typeof v === "boolean" ? v ? 1 : 0 : 2;
     return ret;
   };
+  imports.wbg.__wbindgen_string_new = function(arg0, arg1) {
+    const ret = getStringFromWasm0(arg0, arg1);
+    return addHeapObject(ret);
+  };
   imports.wbg.__wbindgen_is_object = function(arg0) {
     const val = getObject(arg0);
     const ret = typeof val === "object" && val !== null;
     return ret;
   };
-  imports.wbg.__wbindgen_string_new = function(arg0, arg1) {
-    const ret = getStringFromWasm0(arg0, arg1);
-    return addHeapObject(ret);
-  };
   imports.wbg.__wbindgen_object_clone_ref = function(arg0) {
     const ret = getObject(arg0);
     return addHeapObject(ret);
diff --git a/bindings/javascript/wasm/index_bg.wasm b/bindings/javascript/wasm/index_bg.wasm
diff --git a/css-inline/src/lib.rs b/css-inline/src/lib.rs
@@ -388,6 +388,11 @@ fn load_external(location: &str) -> Result<String> {
                 ErrorKind::NotFound => InlineError::MissingStyleSheet {
                     path: location.to_string(),
                 },
+                #[cfg(target_family = "wasm")]
+                ErrorKind::Unsupported => InlineError::IO(std::io::Error::new(
+                    ErrorKind::Unsupported,
+                    format!("Loading local files is not supported on WASM: {location}"),
+                )),
                 _ => InlineError::IO(error),
             })
         }
