From 9f03876ae518102346d9fa6bd3d07a59ae2cee7c Mon Sep 17 00:00:00 2001 From: Stepami Date: Sun, 23 Aug 2026 14:24:25 +0300 Subject: [PATCH] test(naming): roy osherove --- .../SuccessfulProgramsTests.cs | 2 +- ...FunctionWithUndefinedReturnStorageTests.cs | 6 +++--- .../Application/SymbolTableTests.cs | 4 ++-- .../TypeDeclarationsResolverTests.cs | 2 +- .../BackEnd/AddressedInstructionsTests.cs | 8 +++---- .../Domain/BackEnd/CallTests.cs | 4 ++-- .../Domain/BackEnd/HashAddressTests.cs | 8 +++---- .../Domain/BackEnd/InstructionsData.cs | 2 +- .../Domain/BackEnd/TestVirtualMachine.cs | 2 +- .../Domain/BackEnd/ValuesTests.cs | 18 ++++++++-------- .../Domain/BackEnd/VirtualMachineTests.cs | 20 ++++++++---------- .../Domain/FrontEnd/LexerInput.cs | 6 ++++-- .../Domain/FrontEnd/RegexLexerTests.cs | 10 ++++----- .../Domain/FrontEnd/StructureTests.cs | 4 ++-- .../Domain/IR/ObjectTypeTests.cs | 21 +++++++++---------- .../Domain/IR/TypeTests.cs | 10 ++++----- 16 files changed, 63 insertions(+), 64 deletions(-) diff --git a/tests/HydraScript.IntegrationTests/SuccessPrograms/SuccessfulProgramsTests.cs b/tests/HydraScript.IntegrationTests/SuccessPrograms/SuccessfulProgramsTests.cs index 609055bd..e620e7a4 100644 --- a/tests/HydraScript.IntegrationTests/SuccessPrograms/SuccessfulProgramsTests.cs +++ b/tests/HydraScript.IntegrationTests/SuccessPrograms/SuccessfulProgramsTests.cs @@ -16,7 +16,7 @@ public void Invoke_NoError_ReturnCodeIsZero(string relativePathToFile) runner.Invoke().Should().Be(Executor.ExitCodes.Success); } - public class SuccessfulPrograms : TheoryData + public sealed class SuccessfulPrograms : TheoryData { public SuccessfulPrograms() { diff --git a/tests/HydraScript.UnitTests/Application/FunctionWithUndefinedReturnStorageTests.cs b/tests/HydraScript.UnitTests/Application/FunctionWithUndefinedReturnStorageTests.cs index c7f573e5..4c70688b 100644 --- a/tests/HydraScript.UnitTests/Application/FunctionWithUndefinedReturnStorageTests.cs +++ b/tests/HydraScript.UnitTests/Application/FunctionWithUndefinedReturnStorageTests.cs @@ -13,7 +13,7 @@ public class FunctionWithUndefinedReturnStorageTests private const string FunctionName = nameof(FunctionName); [Fact] - public void StorageIsEmptyAfterFlushTest() + public void Flush_AfterSave_ReturnsSavedDeclarationAndClearsStorage() { IFunctionWithUndefinedReturnStorage storage = new FunctionWithUndefinedReturnStorage(); @@ -38,7 +38,7 @@ public void StorageIsEmptyAfterFlushTest() } [Fact] - public void StorageIsCorrectOrderTest() + public void Flush_MultipleSavedDeclarations_ReturnsInSaveOrder() { FunctionDeclaration[] declarations = [ new( @@ -101,4 +101,4 @@ public void StorageIsCorrectOrderTest() Assert.Equal([declarations[0], declarations[2], declarations[3]], storage.Flush()); } -} \ No newline at end of file +} diff --git a/tests/HydraScript.UnitTests/Application/SymbolTableTests.cs b/tests/HydraScript.UnitTests/Application/SymbolTableTests.cs index 5461123c..1d7e7643 100644 --- a/tests/HydraScript.UnitTests/Application/SymbolTableTests.cs +++ b/tests/HydraScript.UnitTests/Application/SymbolTableTests.cs @@ -6,7 +6,7 @@ namespace HydraScript.UnitTests.Application; public class SymbolTableTests { [Theory, AutoHydraScriptData] - public void FindSymbolTest(ISymbol symbol) + public void FindSymbol_OpenScopeContainsSymbol_ReturnsSymbol(ISymbol symbol) { var id = symbol.Id; @@ -18,4 +18,4 @@ public void FindSymbolTest(ISymbol symbol) Assert.NotNull(innerScope.FindSymbol(id)); Assert.True(outerScope.ContainsSymbol(id)); } -} \ No newline at end of file +} diff --git a/tests/HydraScript.UnitTests/Application/TypeDeclarationsResolverTests.cs b/tests/HydraScript.UnitTests/Application/TypeDeclarationsResolverTests.cs index 2e9b2d9d..78b2a6a8 100644 --- a/tests/HydraScript.UnitTests/Application/TypeDeclarationsResolverTests.cs +++ b/tests/HydraScript.UnitTests/Application/TypeDeclarationsResolverTests.cs @@ -25,7 +25,7 @@ public void Resolve_Issue231_Success() // Arrange const string itemTypeName = "QueryStringParseResultItem"; const string resultTypeName = "QueryStringParseResult"; - + var scope = new Scope(); var symbolTable = new SymbolTable(); symbolTable.AddSymbol(new TypeSymbol(itemTypeName)); diff --git a/tests/HydraScript.UnitTests/Domain/BackEnd/AddressedInstructionsTests.cs b/tests/HydraScript.UnitTests/Domain/BackEnd/AddressedInstructionsTests.cs index 77996782..1c143dc1 100644 --- a/tests/HydraScript.UnitTests/Domain/BackEnd/AddressedInstructionsTests.cs +++ b/tests/HydraScript.UnitTests/Domain/BackEnd/AddressedInstructionsTests.cs @@ -10,7 +10,7 @@ namespace HydraScript.UnitTests.Domain.BackEnd; public class AddressedInstructionsTests { [Fact] - public void EnumerationPreservedAfterRemovalTest() + public void Remove_MiddleInstruction_PreservesEnumeration() { AddressedInstructions instructions = [ @@ -28,7 +28,7 @@ public void EnumerationPreservedAfterRemovalTest() } [Fact] - public void RemovalOfLastDoesNotThrowTest() + public void Remove_LastInstruction_DoesNotThrow() { AddressedInstructions instructions = [ @@ -41,7 +41,7 @@ public void RemovalOfLastDoesNotThrowTest() } [Fact] - public void ReplacementPreservesOrderTest() + public void Replace_MiddleInstruction_PreservesOrder() { var instructions = new AddressedInstructions { @@ -67,4 +67,4 @@ public void ReplacementPreservesOrderTest() Assert.Same(@new, instructions[prev.Address.Next!]); Assert.Same(next, instructions[@new.Address.Next!]); } -} \ No newline at end of file +} diff --git a/tests/HydraScript.UnitTests/Domain/BackEnd/CallTests.cs b/tests/HydraScript.UnitTests/Domain/BackEnd/CallTests.cs index 931c10f0..b81c99b1 100644 --- a/tests/HydraScript.UnitTests/Domain/BackEnd/CallTests.cs +++ b/tests/HydraScript.UnitTests/Domain/BackEnd/CallTests.cs @@ -6,7 +6,7 @@ namespace HydraScript.UnitTests.Domain.BackEnd; public class CallTests { [Fact] - public void ToStringCorrect() + public void ToString_Always_Success() { var call = new Call( new Label("9"), @@ -14,4 +14,4 @@ public void ToStringCorrect() const string expected = "9:\n\t: => Start_func:\n\t: func"; Assert.Equal(expected, call.ToString()); } -} \ No newline at end of file +} diff --git a/tests/HydraScript.UnitTests/Domain/BackEnd/HashAddressTests.cs b/tests/HydraScript.UnitTests/Domain/BackEnd/HashAddressTests.cs index 16d02b72..5d5cd687 100644 --- a/tests/HydraScript.UnitTests/Domain/BackEnd/HashAddressTests.cs +++ b/tests/HydraScript.UnitTests/Domain/BackEnd/HashAddressTests.cs @@ -5,7 +5,7 @@ namespace HydraScript.UnitTests.Domain.BackEnd; public class HashAddressTests { [Fact] - public void EqualsReturnsFalseForTwoDifferentObjectsWithSameSeed() + public void Equals_DifferentObjectsWithSameSeed_ReturnsFalse() { const int seed = 1; @@ -16,7 +16,7 @@ public void EqualsReturnsFalseForTwoDifferentObjectsWithSameSeed() } [Fact] - public void EqualsReturnsTrueForTwoSameObjectsWithSameSeed() + public void Equals_SameObjectWithSameSeed_ReturnsTrue() { var address = new HashAddress(1); @@ -24,11 +24,11 @@ public void EqualsReturnsTrueForTwoSameObjectsWithSameSeed() } [Fact] - public void EqualsReturnsFalseForTwoObjectsWithDifferentSeed() + public void Equals_ObjectsWithDifferentSeed_ReturnsFalse() { var addressOne = new HashAddress(0); var addressTwo = new HashAddress(1); Assert.NotEqual(addressOne, addressTwo); } -} \ No newline at end of file +} diff --git a/tests/HydraScript.UnitTests/Domain/BackEnd/InstructionsData.cs b/tests/HydraScript.UnitTests/Domain/BackEnd/InstructionsData.cs index d7a3c63b..d35cc7c1 100644 --- a/tests/HydraScript.UnitTests/Domain/BackEnd/InstructionsData.cs +++ b/tests/HydraScript.UnitTests/Domain/BackEnd/InstructionsData.cs @@ -10,7 +10,7 @@ namespace HydraScript.UnitTests.Domain.BackEnd; -public class InstructionsData : TheoryData +public sealed class InstructionsData : TheoryData { public InstructionsData() { diff --git a/tests/HydraScript.UnitTests/Domain/BackEnd/TestVirtualMachine.cs b/tests/HydraScript.UnitTests/Domain/BackEnd/TestVirtualMachine.cs index 0ef486af..1b3a691b 100644 --- a/tests/HydraScript.UnitTests/Domain/BackEnd/TestVirtualMachine.cs +++ b/tests/HydraScript.UnitTests/Domain/BackEnd/TestVirtualMachine.cs @@ -4,7 +4,7 @@ namespace HydraScript.UnitTests.Domain.BackEnd; -public class TestVirtualMachine(IConsole console, IFrameContext frameContext) : +public sealed class TestVirtualMachine(IConsole console, IFrameContext frameContext) : VirtualMachine(console, frameContext) { private readonly IFrameContext _frameContext = frameContext; diff --git a/tests/HydraScript.UnitTests/Domain/BackEnd/ValuesTests.cs b/tests/HydraScript.UnitTests/Domain/BackEnd/ValuesTests.cs index fd74384d..93871e6d 100644 --- a/tests/HydraScript.UnitTests/Domain/BackEnd/ValuesTests.cs +++ b/tests/HydraScript.UnitTests/Domain/BackEnd/ValuesTests.cs @@ -6,40 +6,40 @@ namespace HydraScript.UnitTests.Domain.BackEnd; public class ValuesTests { [Fact] - public void ConstantNotEqualToNameTest() + public void Equals_ConstantComparedWithName_ReturnsFalse() { var name = new Name("a", Substitute.For