Clean_up_01

Author: goedman

src/methods/adjustment_sets.jl

@@ -9,9 +9,8 @@ $(SIGNATURES)
 Part of the API, Exported
 """
 function syms_in_paths(paths, f, l)
-  thepaths = deepcopy(paths)
   syms = Symbol[]
-  for p in thepaths
+  for p in paths
     setdiff!(p, [f, l])
     append!(syms, p)
     unique!(syms)
@@ -44,22 +43,22 @@ $(SIGNATURES)
 
 Part of the API, Exported
 """
-function adjustment_sets(d::DAG, f::Symbol, l::Symbol; debug=false)
+function adjustment_sets(dag::DAG, f::Symbol, l::Symbol; debug=false)
 
-  ap  = all_paths(d, f, l)
-  paths = backdoor_paths(d, ap, f)
+  ap  = all_paths(dag, f, l)
+  paths = backdoor_paths(dag, ap, f)
   debug && display(paths)
   lsyms = syms_in_paths(paths, f, l)
   adjustmentsets = Vector{Symbol}[]
   for s in lsyms
     debug && println("checking $s in $lsyms")
     if sym_in_all_paths(paths, s)
-      opensets = length(open_paths(d, paths, [s]))
+      opensets = length(open_paths(dag, paths, [s]))
       if  opensets == 0
         debug && println("$s closes all paths.")
         append!(adjustmentsets, [[s]])
       end
-    elseif length(open_paths(d, paths, [s])) == 0
+    elseif length(open_paths(dag, paths, [s])) == 0
         debug && println("$s not in all paths but no open paths.")
         append!(adjustmentsets, [[s]])
     end
@@ -74,7 +73,7 @@ function adjustment_sets(d::DAG, f::Symbol, l::Symbol; debug=false)
     csyms = collect(combinations(lsyms, len))
     debug && csyms |> display
     for s in csyms
-      if length(open_paths(d, paths, s)) == 0
+      if length(open_paths(dag, paths, s)) == 0
         debug && println("$s closes all paths")
         append!(adjustmentsets, [s])
         setdiff!(lsyms, s)

src/methods/pcor.jl

@@ -53,7 +53,7 @@ The Julia translation is licenced under: MIT.
 
 Part of the api, not exported.
 """
-function pcor(d:: DAG, u::SymbolList)
+function pcor(d::DAG, u::SymbolList)
   us = String.(u)
   k = inv(d.s[us, us])
   -k[1,2] / sqrt(k[1,1] * k[2,2])

test/test_descendents_03.jl

@@ -1,5 +1,7 @@
 using StructuralCausalModels, Test
 
+ProjDir = @__DIR__
+
 d_str = "dag{k1 -> k2;k2 -> y;v -> x2;w -> k1;x1 -> v;x1 -> w;x2 -> y;x3 -> w;x3 -> y}"
 
 dag = DAG("test_desc", d_str)
@@ -8,7 +10,7 @@ to_dagitty(dag)
 
 fname = joinpath(ProjDir, "test_descendents_03.dot")
 to_graphviz(dag, fname)
-#Sys.isapple() && run(`open -a GraphViz.app $(fname)`)
+Sys.isapple() && run(`open -a GraphViz.app $(fname)`)
 
 bs = basis_set(dag)
 as = adjustment_sets(dag, :x2, :y)