From 68805124e14b05178418ac6201f5cfc6356dd6ab Mon Sep 17 00:00:00 2001 From: Matt <47545907+SoundMatt@users.noreply.github.com> Date: Thu, 30 Jul 2026 15:35:58 -0700 Subject: [PATCH] ci: bump pinned RELAY conformance validator to v2.0.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RELAY tagged v2.0.4 today to fix issue #70: go.mod's module path hadn't picked up the /v2 suffix required by Go's semantic import versioning after the v2.0 MAJOR bump, making v2.0.0+ tags uninstallable via go install/go get. cpp-RCP builds RELAY from a local checkout rather than go install, so it was never actually blocked by that bug, but the relay-conform job's pin (issue #83 / cpp-RCP-15) is now stale and should track a current tagged release. Bumps the "Checkout RELAY (authoritative conformance validator)" step's ref from 3344b3d1a6a4d870d26c81c6f3c3ff5ca2930e16 (v2.0.2) to 810d1877362145a407b865426bb007657e42d00f (v2.0.4) — the tag's actual commit SHA, not the annotated tag object SHA (f3eeb69d...), which resolves to this same commit but isn't itself a commit. Verified locally before pushing, building RELAY at this exact pinned commit the same way CI does: - `relay conform --strict build/cpp-rcp` PASSES. - `relay interop --strict --protocol RCP build/cpp-rcp` fails only because cpp-RCP has never implemented the optional `convert` subcommand (confirmed pre-existing and identical against the old v2.0.2 pin, so not a regression from this bump). Per RELAY spec §20.1/§20.3, the interop/behavioural-conformance CI gate applies "once convert is implemented" and is required only for the Tooling-conformant tier (convert + subscribe --format json + streaming send --format json); cpp-RCP is Core-conformant only and has never claimed convert in its capabilities, so this is a legitimate, known scope boundary, not a conformance gap to fix here. Non-strict interop (matching cpp-RCP's actual capabilities) reports SKIP/PASS. - Reviewed RELAY spec/CHANGELOG.md v2.0.1-v2.0.4: all four are tooling/doc/bug-fix patch releases with SpecVersion unchanged at 2.0 (no normative change), so no RCP-side canonical-type or wire-format work is needed. Also ran this repo's full local build/test suite against the bumped pin: cmake+ninja build (213/213 targets), ctest (52/52 passed), clang-tidy scoped to tests/*.cpp (clean aside from a pre-existing, untouched-by-this-change bugprone-infinite-loop false positive in test_request.cpp from a newer local clang-tidy than CI's pinned clang-14/Ubuntu-22.04 toolchain), and the ASan/UBSan test_regmap job (132 assertions, 23 test cases, clean). No cpp-FuSa binary is available in this local environment to run standalone. No behavior change and no conformance gap found, so no version bump (cpp-rcp stays at 2.19.0): CI-workflow-only change, consistent with this repo's convention of reserving version bumps for commits that touch library code or behavior. Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2802b2c..caf4da0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -103,7 +103,7 @@ jobs: uses: actions/checkout@v4 with: repository: SoundMatt/RELAY - ref: 3344b3d1a6a4d870d26c81c6f3c3ff5ca2930e16 # v2.0.2 + ref: 810d1877362145a407b865426bb007657e42d00f # v2.0.4 path: RELAY - name: Set up Go