|
32 | 32 | import org.sonar.python.types.v2.TypeUtils; |
33 | 33 |
|
34 | 34 | public class TrivialTypePropagationVisitor extends BaseTreeVisitor { |
35 | | - private TypeCheckBuilder isBooleanTypeCheck; |
36 | | - private TypeCheckBuilder isIntTypeCheck; |
37 | | - private TypeCheckBuilder isFloatTypeCheck; |
38 | | - private TypeCheckBuilder isComplexTypeCheck; |
| 35 | + private final TypeCheckBuilder isBooleanTypeCheck; |
| 36 | + private final TypeCheckBuilder isIntTypeCheck; |
| 37 | + private final TypeCheckBuilder isFloatTypeCheck; |
| 38 | + private final TypeCheckBuilder isComplexTypeCheck; |
39 | 39 |
|
40 | | - private PythonType intType; |
41 | | - private PythonType boolType; |
| 40 | + private final PythonType intType; |
| 41 | + private final PythonType boolType; |
42 | 42 |
|
43 | 43 | public TrivialTypePropagationVisitor(TypeTable typeTable) { |
44 | 44 | this.isBooleanTypeCheck = new TypeCheckBuilder(typeTable).isBuiltinWithName(BuiltinTypes.BOOL); |
@@ -76,20 +76,20 @@ private PythonType getTypeWhenUnaryPlusMinus(UnaryExpression unaryExpr) { |
76 | 76 | private PythonType mapUnaryPlusMinusType(PythonType type) { |
77 | 77 | if (isNumber(type)) { |
78 | 78 | return type; |
79 | | - } else if(isBooleanTypeCheck.check(type) == TriBool.TRUE) { |
| 79 | + } else if (isBooleanTypeCheck.check(type) == TriBool.TRUE) { |
80 | 80 | return toObjectType(intType); |
81 | 81 | } |
82 | 82 | return PythonType.UNKNOWN; |
83 | 83 | } |
84 | 84 |
|
85 | | - private boolean isNumber(PythonType type) { |
| 85 | + private boolean isNumber(PythonType type) { |
86 | 86 | return isIntTypeCheck.check(type) == TriBool.TRUE |
87 | 87 | || isFloatTypeCheck.check(type) == TriBool.TRUE |
88 | 88 | || isComplexTypeCheck.check(type) == TriBool.TRUE; |
89 | 89 | } |
90 | 90 |
|
91 | 91 | private static PythonType toObjectType(PythonType type) { |
92 | | - if(type instanceof ObjectType || type == PythonType.UNKNOWN) { |
| 92 | + if (type instanceof ObjectType || type == PythonType.UNKNOWN) { |
93 | 93 | return type; |
94 | 94 | } |
95 | 95 | return new ObjectType(type); |
|
0 commit comments