SONARPY-2412 clean up flask decorator check

Author: Seppli11

python-checks/src/main/java/org/sonar/python/checks/hotspots/UnsafeHttpMethodsCheck.java

@@ -19,7 +19,6 @@
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
-import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
 import org.sonar.check.Rule;
@@ -31,17 +30,14 @@
 import org.sonar.plugins.python.api.tree.CallExpression;
 import org.sonar.plugins.python.api.tree.Decorator;
 import org.sonar.plugins.python.api.tree.Expression;
-import org.sonar.plugins.python.api.tree.FileInput;
 import org.sonar.plugins.python.api.tree.FunctionDef;
 import org.sonar.plugins.python.api.tree.ListLiteral;
 import org.sonar.plugins.python.api.tree.RegularArgument;
 import org.sonar.plugins.python.api.tree.StringLiteral;
 import org.sonar.python.semantic.FunctionSymbolImpl;
 import org.sonar.python.tree.FunctionDefImpl;
-import org.sonar.python.tree.TreeUtils;
 
 import static org.sonar.plugins.python.api.tree.Tree.Kind.CALL_EXPR;
-import static org.sonar.plugins.python.api.tree.Tree.Kind.FILE_INPUT;
 import static org.sonar.plugins.python.api.tree.Tree.Kind.FUNCDEF;
 import static org.sonar.plugins.python.api.tree.Tree.Kind.LIST_LITERAL;
 import static org.sonar.plugins.python.api.tree.Tree.Kind.REGULAR_ARGUMENT;
@@ -137,27 +133,13 @@ private static Optional<CallExpression> getFlaskViewDecorator(FunctionDef functi
 
   private static boolean isFlaskRouteDecorator(CallExpression callExpression) {
     Symbol calleeSymbol = callExpression.calleeSymbol();
-    if (calleeSymbol == null) {
-      return false;
-    }
-    return calleeSymbol.name().equals("route");
+    return calleeSymbol != null && "flask.scaffold.Scaffold.route".equals(calleeSymbol.fullyQualifiedName());
   }
 
   private static void checkFlaskView(CallExpression callExpression, SubscriptionContext ctx) {
     RegularArgument methodsArg = argumentByKeyword("methods", callExpression.arguments());
-    if (methodsArg != null && hasBothUnsafeAndSafeHttpMethods(methodsArg) && isFlaskImported(callExpression)) {
+    if (methodsArg != null && hasBothUnsafeAndSafeHttpMethods(methodsArg)) {
       ctx.addIssue(callExpression, MESSAGE);
     }
   }
-
-  private static boolean isFlaskImported(CallExpression callExpression) {
-    // When SONARPY-834 will be implemented we can have a cleaner implementation
-    // checking decorator fqn to be equal to flask.blueprints.Blueprint.route
-    return Optional.ofNullable(TreeUtils.firstAncestorOfKind(callExpression, FILE_INPUT))
-      .filter(fileInput -> ((FileInput) fileInput).globalVariables().stream()
-          .map(Symbol::fullyQualifiedName)
-          .filter(Objects::nonNull)
-          .anyMatch(fqn -> fqn.contains("flask")))
-      .isPresent();
-  }
 }