SONARPY-2822 Rollback sharing of the ProjectLevelTypeTable across files rules execution (#228)

GitOrigin-RevId: 30a0ccdcbbe75732e85d1f375842808b1e08d1bc

Author: maksim-grebeniuk-sonarsource

python-commons/src/main/java/org/sonar/plugins/python/PythonScanner.java

@@ -118,7 +118,6 @@ protected void scanFile(PythonInputFile inputFile) throws IOException {
         getWorkingDirectory(context),
         indexer.packageName(inputFile),
         indexer.projectLevelSymbolTable(),
-        indexer.projectLevelTypeTable(),
         indexer.cacheContext(),
         context.runtime().getProduct());
       if (fileType == InputFile.Type.MAIN) {

python-commons/src/main/java/org/sonar/plugins/python/indexer/PythonIndexer.java

@@ -56,16 +56,11 @@ public abstract class PythonIndexer {
   private final Map<URI, String> packageNames = new ConcurrentHashMap<>();
   private final Supplier<PythonParser> parserSupplier = PythonParser::create;
   private final ProjectLevelSymbolTable projectLevelSymbolTable = ProjectLevelSymbolTable.empty();
-  private final ProjectLevelTypeTable projectLevelTypeTable = new ProjectLevelTypeTable(projectLevelSymbolTable);
 
   public ProjectLevelSymbolTable projectLevelSymbolTable() {
     return projectLevelSymbolTable;
   }
 
-  public ProjectLevelTypeTable projectLevelTypeTable() {
-    return projectLevelTypeTable;
-  }
-
   public String packageName(PythonInputFile inputFile) {
     if (!packageNames.containsKey(inputFile.wrappedFile().uri())) {
       String name = pythonPackageName(inputFile.wrappedFile().file(), projectBaseDirAbsolutePath);

python-frontend/src/main/java/org/sonar/plugins/python/api/PythonVisitorContext.java

@@ -77,17 +77,12 @@ public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable
 
   public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable File workingDirectory, String packageName,
     ProjectLevelSymbolTable projectLevelSymbolTable, CacheContext cacheContext, SonarProduct sonarProduct) {
-    this(rootTree, pythonFile, workingDirectory, packageName, projectLevelSymbolTable, new ProjectLevelTypeTable(projectLevelSymbolTable), cacheContext, sonarProduct);
-  }
-
-  public PythonVisitorContext(FileInput rootTree, PythonFile pythonFile, @Nullable File workingDirectory, String packageName,
-    ProjectLevelSymbolTable projectLevelSymbolTable, ProjectLevelTypeTable projectLevelTypeTable, CacheContext cacheContext, SonarProduct sonarProduct) {
     super(pythonFile, workingDirectory, cacheContext, sonarProduct, projectLevelSymbolTable);
-
     var symbolTableBuilderV2 = new SymbolTableBuilderV2(rootTree);
     var symbolTable = symbolTableBuilderV2.build();
     var symbolTableBuilder = new SymbolTableBuilder(packageName, pythonFile, projectLevelSymbolTable);
     symbolTableBuilder.visitFileInput(rootTree);
+    var projectLevelTypeTable = new ProjectLevelTypeTable(projectLevelSymbolTable);
     this.moduleType = new TypeInferenceV2(projectLevelTypeTable, pythonFile, symbolTable, packageName).inferModuleType(rootTree);
     this.typeChecker = new TypeChecker(projectLevelTypeTable);
     this.rootTree = rootTree;