SONARPY-4020 S8504 Fix property shadowing tests (#1048)

GitOrigin-RevId: d95038f4fc3260c5c9266d3a05f80d63da24ff2c

Author: joke1196

python-checks/src/main/java/org/sonar/python/checks/PropertyMethodWithoutReturnCheck.java

@@ -28,7 +28,7 @@
 public class PropertyMethodWithoutReturnCheck extends PythonSubscriptionCheck {
 
   private static final String MESSAGE = "Add a return statement to this property method.";
-  private static final TypeMatcher PROPERTY_MATCHER = TypeMatchers.isType("builtins.property");
+  private static final TypeMatcher PROPERTY_MATCHER = TypeMatchers.isType("property");
   private static final TypeMatcher ABSTRACT_METHOD_MATCHER = TypeMatchers.isType("abc.abstractmethod");
 
   @Override

python-checks/src/test/java/org/sonar/python/checks/PropertyMethodWithoutReturnCheckTest.java

@@ -26,4 +26,8 @@ void test() {
     PythonCheckVerifier.verify("src/test/resources/checks/propertyMethodWithoutReturn.py", new PropertyMethodWithoutReturnCheck());
   }
 
+  @Test
+  void test_shadowing_propery() {
+    PythonCheckVerifier.verifyNoIssue("src/test/resources/checks/propertyMethodWithoutReturnShadowingProperty.py", new PropertyMethodWithoutReturnCheck());
+  }
 }

python-checks/src/test/resources/checks/propertyMethodWithoutReturn.py

@@ -201,20 +201,6 @@ def via_finally(self):  # Compliant - return in finally block
             return self._data.get("key")
 
 
-def property(func):
-    """A user-defined decorator that happens to be named 'property'."""
-    return func
-
-
-class UserDefinedPropertyDecorator:
-    def __init__(self):
-        self._value = 0
-
-    @property
-    def value(self):  # Compliant - built-in 'property' is shadowed by the user-defined decorator above; type matcher correctly excludes this
-        self._value * 2
-
-
 import functools
 
 

python-checks/src/test/resources/checks/propertyMethodWithoutReturnShadowingProperty.py

@@ -0,0 +1,14 @@
+
+def property(func):
+    """A user-defined decorator that happens to be named 'property'."""
+    return func
+
+
+class UserDefinedPropertyDecorator:
+    def __init__(self):
+        self._value = 0
+
+    @property
+    def value(self):  # Compliant - built-in 'property' is shadowed by the user-defined decorator above; type matcher correctly excludes this
+        self._value * 2
+