SONARPY-2978 Instantiate a new TypeCheckMap on every file (#281)

GitOrigin-RevId: 1edbe8898e8b1b25e377606eb9ee0aefc383c5d4

Author: ghislainpiot

python-checks/src/main/java/org/sonar/python/checks/PredictableSaltCheck.java

@@ -76,13 +76,19 @@ public class PredictableSaltCheck extends PythonSubscriptionCheck {
     "base64.b16encode", new ArgumentInfo(0, "s"),
     "base64.b16decode", new ArgumentInfo(0, "s"));
 
+  private TypeCheckMap<ArgumentInfo> sensitiveArgumentByFqnCheck;
+  private TypeCheckMap<ArgumentInfo> saltFunctionArgumentsToCheck;
+  private List<TypeCheckBuilder> deriveFunctionsToCheck;
+
   @Override
   public void initialize(Context context) {
-    var sensitiveArgumentByFqnCheck = new TypeCheckMap<ArgumentInfo>();
-    var saltFunctionArgumentsToCheck = new TypeCheckMap<ArgumentInfo>();
-    var deriveFunctionsToCheck = new ArrayList<TypeCheckBuilder>();
-    context.registerSyntaxNodeConsumer(Tree.Kind.FILE_INPUT, ctx -> initializeTypeChecks(ctx, sensitiveArgumentByFqnCheck,
-      saltFunctionArgumentsToCheck, deriveFunctionsToCheck));
+    context.registerSyntaxNodeConsumer(Tree.Kind.FILE_INPUT, ctx -> {
+      sensitiveArgumentByFqnCheck = new TypeCheckMap<>();
+      saltFunctionArgumentsToCheck = new TypeCheckMap<>();
+      deriveFunctionsToCheck = new ArrayList<>();
+      initializeTypeChecks(ctx, sensitiveArgumentByFqnCheck,
+        saltFunctionArgumentsToCheck, deriveFunctionsToCheck);
+    });
     context.registerSyntaxNodeConsumer(Tree.Kind.CALL_EXPR, ctx -> handleCallExpression((CallExpression) ctx.syntaxNode(),
       ctx,
       sensitiveArgumentByFqnCheck,

python-checks/src/main/java/org/sonar/python/checks/RewriteCollectionConstructorAsComprehensionCheck.java

@@ -45,8 +45,8 @@ public class RewriteCollectionConstructorAsComprehensionCheck extends PythonSubs
   @Override
   public void initialize(Context context) {
     IsComprehensionTransformedChecker isComprehensionTransformedChecker = new IsComprehensionTransformedChecker(context);
-    collectionTypeCheckerMap = new TypeCheckMap<>();
     context.registerSyntaxNodeConsumer(Tree.Kind.FILE_INPUT, ctx -> {
+      collectionTypeCheckerMap = new TypeCheckMap<>();
       for (var collectionEntry : COLLECTION_MESSAGES.entrySet()) {
         TypeCheckBuilder typeChecker = ctx.typeChecker().typeCheckBuilder().isTypeWithFqn(collectionEntry.getKey());
         collectionTypeCheckerMap.put(typeChecker, collectionEntry.getValue());

python-checks/src/main/java/org/sonar/python/checks/SynchronousFileOperationsInAsyncCheck.java

@@ -32,7 +32,7 @@ public class SynchronousFileOperationsInAsyncCheck extends PythonSubscriptionChe
   private static final String MESSAGE = "Use an asynchronous file API instead of synchronous %s() in this async function.";
   private static final String SECONDARY_MESSAGE = "This function is async.";
 
-  private final TypeCheckMap<String> syncFileFunctions = new TypeCheckMap<>();
+  private TypeCheckMap<String> syncFileFunctions;
 
   @Override
   public void initialize(Context context) {
@@ -55,6 +55,7 @@ public void initialize(Context context) {
     "lzma.open");
 
   private void initializeTypeCheckMap(SubscriptionContext context) {
+    syncFileFunctions = new TypeCheckMap<>();
     SYNC_FILE_FUNCTIONS.forEach(fqn -> syncFileFunctions.put(context.typeChecker().typeCheckBuilder().isTypeOrInstanceWithName(fqn), fqn));
   }
 

python-checks/src/main/java/org/sonar/python/checks/SynchronousHttpOperationsInAsyncCheck.java

@@ -59,7 +59,7 @@ public class SynchronousHttpOperationsInAsyncCheck extends PythonSubscriptionChe
     "httpx.options",
     "httpx.patch");
 
-  private final TypeCheckMap<Object> syncHttpTypeChecks = new TypeCheckMap<>();
+  private TypeCheckMap<Object> syncHttpTypeChecks;
 
   @Override
   public void initialize(Context context) {
@@ -68,6 +68,7 @@ public void initialize(Context context) {
   }
 
   private void setupTypeChecks(SubscriptionContext ctx) {
+    syncHttpTypeChecks = new TypeCheckMap<>();
     var object = new Object();
     IMPORT_PATHS.forEach(path -> syncHttpTypeChecks.put(ctx.typeChecker().typeCheckBuilder().isTypeOrInstanceWithName(path), object));
     IMPORT_PATHS_FQN.forEach(path -> syncHttpTypeChecks.put(ctx.typeChecker().typeCheckBuilder().isTypeWithFqn(path), object));

python-checks/src/main/java/org/sonar/python/checks/SynchronousOsCallsInAsyncCheck.java

@@ -36,7 +36,7 @@ public class SynchronousOsCallsInAsyncCheck extends PythonSubscriptionCheck {
     "os.waitid"
   );
 
-  private final TypeCheckMap<Object> syncOsCallsTypeChecks = new TypeCheckMap<>();
+  private TypeCheckMap<Object> syncOsCallsTypeChecks;
 
   @Override
   public void initialize(Context context) {
@@ -45,8 +45,9 @@ public void initialize(Context context) {
   }
 
   private void setupTypeChecks(SubscriptionContext ctx) {
+    syncOsCallsTypeChecks = new TypeCheckMap<>();
     var object = new Object();
-    OS_BLOCKING_CALLS.forEach(path -> 
+    OS_BLOCKING_CALLS.forEach(path ->
       syncOsCallsTypeChecks.put(ctx.typeChecker().typeCheckBuilder().isTypeOrInstanceWithName(path), object));
   }
 

python-checks/src/main/java/org/sonar/python/checks/hotspots/FastHashingOrPlainTextCheck.java

@@ -233,7 +233,7 @@ public class FastHashingOrPlainTextCheck extends PythonSubscriptionCheck {
 
   private TypeCheckBuilder argon2CheapestProfileTypeChecker = null;
   private TypeCheckBuilder flaskConfigTypeChecker = null;
-  private TypeCheckMap<Collection<CallValidator>> typeCheckMap = new TypeCheckMap<>();
+  private TypeCheckMap<Collection<CallValidator>> typeCheckMap = null;
   @Override
   public void initialize(Context context) {
     context.registerSyntaxNodeConsumer(Tree.Kind.FILE_INPUT, this::registerTypeCheckers);