SONARPY-3862 S6542 Removed check on variadic parameters (#916)

GitOrigin-RevId: b1d88e70a41c08684962983e79221c71ecb862d1

Author: joke1196

python-checks/src/main/java/org/sonar/python/checks/UseOfAnyAsTypeHintCheck.java

@@ -26,6 +26,7 @@
 import org.sonar.plugins.python.api.tree.Decorator;
 import org.sonar.plugins.python.api.tree.FunctionDef;
 import org.sonar.plugins.python.api.tree.Name;
+import org.sonar.plugins.python.api.tree.Parameter;
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.tree.TypeAnnotation;
 import org.sonar.python.semantic.SymbolUtils;
@@ -55,12 +56,20 @@ private static void checkForAnyInReturnTypeAndParameters(SubscriptionContext ctx
     TypeAnnotation typeAnnotation = (TypeAnnotation) ctx.syntaxNode();
     Optional.of(typeAnnotation)
       .filter(UseOfAnyAsTypeHintCheck::isTypeAny)
+      .filter(Predicate.not(UseOfAnyAsTypeHintCheck::isVariadicParameter))
       .map(annotation -> (FunctionDef) TreeUtils.firstAncestorOfKind(annotation, Tree.Kind.FUNCDEF))
       .filter(Predicate.not(UseOfAnyAsTypeHintCheck::hasFunctionOverrideOrOverloadDecorator))
       .filter(Predicate.not(UseOfAnyAsTypeHintCheck::canFunctionBeAnOverride))
       .ifPresent(functionDef -> ctx.addIssue(typeAnnotation.expression(), MESSAGE));
   }
 
+  private static boolean isVariadicParameter(TypeAnnotation typeAnnotation) {
+    return Optional.ofNullable(typeAnnotation.parent())
+      .flatMap(TreeUtils.toOptionalInstanceOfMapper(Parameter.class))
+      .map(Parameter::starToken)
+      .isPresent();
+  }
+
   private static boolean isTypeAny(@Nullable TypeAnnotation typeAnnotation) {
     return Optional.ofNullable(typeAnnotation)
       .map(TypeAnnotation::expression)

python-checks/src/test/resources/checks/useOfAnyAsTypeHintCheck/useOfAnyAsTypeHint.py

@@ -126,3 +126,26 @@ class LocalClassWithAnnotatedMember:
 class LocalClassChild(LocalClassWithAnnotatedMember):
   def my_member(self, param: Any) -> Any: # OK, defined in parent
     ...
+
+# Variadic parameters (*args, **kwargs) should not raise issues
+def function_with_args(*args: Any) -> None:  # Compliant
+    pass
+
+def function_with_kwargs(**kwargs: Any) -> None:  # Compliant
+    pass
+
+def function_with_both(*some_args: Any, **kwargs: Any) -> None:  # Compliant
+    pass
+
+def function_with_mixed(param: Any, *args: Any, **kwargs: Any) -> str:  # Noncompliant
+    pass
+
+class ClassWithVariadicMethods:
+    def method_with_args(self, *args: Any) -> None:  # Compliant
+        pass
+
+    def method_with_kwargs(self, **kwargs: Any) -> None:  # Compliant
+        pass
+
+    def method_with_both(self, param: Any, *args: Any, **kwargs: Any) -> Any:  # Noncompliant 2
+        pass