SONARPY-2891 Add synchronization to the WriteCache to avoid corruption (#240)

ghislainpiot · sonartech · commit 482506bf9aa9 · 2025-04-30T09:28:52.000Z
GitOrigin-RevId: 16e9458b65c04e9498a75050f7e2c2392d77198f
diff --git a/python-frontend/src/main/java/org/sonar/python/caching/PythonWriteCacheImpl.java b/python-frontend/src/main/java/org/sonar/python/caching/PythonWriteCacheImpl.java
@@ -21,14 +21,14 @@
 
 public class PythonWriteCacheImpl implements PythonWriteCache {
 
-  private WriteCache writeCache;
+  private final WriteCache writeCache;
 
   public PythonWriteCacheImpl(WriteCache writeCache) {
     this.writeCache = writeCache;
   }
 
   @Override
-  public void write(String key, byte[] data) {
+  public synchronized void write(String key, byte[] data) {
     this.writeCache.write(key, data);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,14 @@`
`21`	`21`
`22`	`22`	`public class PythonWriteCacheImpl implements PythonWriteCache {`
`23`	`23`
`24`		`- private WriteCache writeCache;`
	`24`	`+ private final WriteCache writeCache;`
`25`	`25`
`26`	`26`	`public PythonWriteCacheImpl(WriteCache writeCache) {`
`27`	`27`	`this.writeCache = writeCache;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`@Override`
`31`		`- public void write(String key, byte[] data) {`
	`31`	`+ public synchronized void write(String key, byte[] data) {`
`32`	`32`	`this.writeCache.write(key, data);`
`33`	`33`	`}`
`34`	`34`